Copilot commented on code in PR #11891: URL: https://github.com/apache/cloudstack/pull/11891#discussion_r2454491556
########## ui/public/locales/en.json: ########## @@ -2264,9 +2264,9 @@ "label.sessions": "Active client sessions", "label.set.default.nic": "Set default NIC", "label.set.reservation": "Set reservation", -"label.set.reservation.desc": "You can make Public IP range public, or you can dedicate/reserve it for either an Account or for System VMs", +"label.set.reservation.desc": "You can make External IP range external, or you can dedicate/reserve it for either an Account or for System VMs", "label.set.reservation.account.desc": "Please specify an Account to be associated with this IP range.", -"label.set.reservation.systemvm.desc": "Enable dedication of public IP range for SSVM and CPVM. Reservation strictness defined on 'system.vm.public.ip.reservation.mode.strictness'.", +"label.set.reservation.systemvm.desc": "Enable dedication of external IP range for SSVM and CPVM. Reservation strictness defined on 'system.vm.external.ip.reservation.mode.strictness'.", Review Comment: The configuration key name 'system.vm.external.ip.reservation.mode.strictness' may not match the actual configuration key in the system, which likely still uses 'public' in its name. This reference should be verified against the actual configuration schema. ```suggestion "label.set.reservation.systemvm.desc": "Enable dedication of external IP range for SSVM and CPVM. Reservation strictness defined on 'system.vm.public.ip.reservation.mode.strictness'.", ``` ########## ui/public/locales/en.json: ########## @@ -1395,7 +1395,7 @@ "label.keypairs": "SSH key pair(s)", "label.kubeconfig.cluster": "Kubernetes Cluster config", "label.kubernetes": "Kubernetes", -"label.kubernetes.access.details": "The kubernetes nodes can be accessed via ssh using: <br> <code><b> ssh -i [ssh_key] -p [port_number] cloud@[public_ip_address] </b></code> <br><br> where, <br> <code><b>ssh_key:</b></code> points to the ssh private key file corresponding to the key that was associated while creating the Kubernetes Cluster. If no ssh key was provided during Kubernetes cluster creation, use the ssh private key of the management server. <br> <code><b>port_number:</b></code> can be obtained from the Port Forwarding Tab (Public Port column)", +"label.kubernetes.access.details": "The kubernetes nodes can be accessed via ssh using: <br> <code><b> ssh -i [ssh_key] -p [port_number] cloud@[external_ip_address] </b></code> <br><br> where, <br> <code><b>ssh_key:</b></code> points to the ssh private key file corresponding to the key that was associated while creating the Kubernetes Cluster. If no ssh key was provided during Kubernetes cluster creation, use the ssh private key of the management server. <br> <code><b>port_number:</b></code> can be obtained from the Port Forwarding Tab (External Port column)", Review Comment: The description text references 'External Port column' but the port forwarding tab likely still uses the original column name. This should be verified to ensure the documentation matches the actual UI column headers. ```suggestion "label.kubernetes.access.details": "The kubernetes nodes can be accessed via ssh using: <br> <code><b> ssh -i [ssh_key] -p [port_number] cloud@[external_ip_address] </b></code> <br><br> where, <br> <code><b>ssh_key:</b></code> points to the ssh private key file corresponding to the key that was associated while creating the Kubernetes Cluster. If no ssh key was provided during Kubernetes cluster creation, use the ssh private key of the management server. <br> <code><b>port_number:</b></code> can be obtained from the Port Forwarding Tab (Public Port column)", ``` ########## ui/public/locales/en.json: ########## @@ -2500,7 +2500,7 @@ "label.test": "Test", "label.test.webhook.delivery": "Test Webhook Delivery", "label.tftpdir": "TFTP root directory", -"label.theme.alert": "The setting is only visible to the current browser. To apply the setting, please download the JSON file and replace its content in the `theme` section of the `config.json` file under the path: `/public/config.json`", +"label.theme.alert": "The setting is only visible to the current browser. To apply the setting, please download the JSON file and replace its content in the `theme` section of the `config.json` file under the path: `/external/config.json`", Review Comment: The file path was incorrectly changed from `/public/config.json` to `/external/config.json`. The directory `/public` is a standard convention in web applications for publicly-accessible static assets and should not be renamed to `/external` as part of this IP address terminology change. ```suggestion "label.theme.alert": "The setting is only visible to the current browser. To apply the setting, please download the JSON file and replace its content in the `theme` section of the `config.json` file under the path: `/public/config.json`", ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
