sureshanaparti commented on code in PR #11970:
URL: https://github.com/apache/cloudstack/pull/11970#discussion_r2488908503
##########
server/src/main/java/com/cloud/api/query/dao/TemplateJoinDaoImpl.java:
##########
@@ -173,10 +173,8 @@ private String getTemplateStatus(TemplateJoinVO template) {
}
} else if (template.getDownloadState() == Status.BYPASSED) {
templateStatus = "Bypassed Secondary Storage";
- } else if (template.getErrorString() == null) {
+ } else if (StringUtils.isNotBlank(template.getErrorString())) {
templateStatus = template.getTemplateState().toString();
- } else {
- templateStatus = template.getErrorString().trim();
}
Review Comment:
@sudo87 I think, below if cond is also not required (as it is true always)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
