DaanHoogland commented on code in PR #12018:
URL: https://github.com/apache/cloudstack/pull/12018#discussion_r2503615796
##########
core/src/main/java/com/cloud/storage/template/HttpTemplateDownloader.java:
##########
@@ -151,7 +151,7 @@ private void checkCredentials(String user, String password)
{
client.getParams().setAuthenticationPreemptive(true);
Credentials defaultcreds = new
UsernamePasswordCredentials(user, password);
client.getState().setCredentials(new
AuthScope(hostAndPort.first(), hostAndPort.second(), AuthScope.ANY_REALM),
defaultcreds);
- logger.info("Added username=" + user + ", password=" +
password + "for host " + hostAndPort.first() + ":" + hostAndPort.second());
+ logger.info("Added username=" + user + ", password=******" + "
for host " + hostAndPort.first() + ":" + hostAndPort.second());
Review Comment:
```suggestion
logger.info("Added username={}" + user + ", password=******
for host {}:{}”, hostAndPort.first(), hostAndPort.second());
```
##########
plugins/hypervisors/baremetal/src/main/java/com/cloud/baremetal/networkservice/BaremetalDnsmasqResource.java:
##########
@@ -46,10 +46,10 @@ public boolean configure(String name, Map<String, Object>
params) throws Configu
com.trilead.ssh2.Connection sshConnection = null;
try {
super.configure(name, params);
- logger.debug(String.format("Trying to connect to DHCP
server(IP=%1$s, username=%2$s, password=%3$s)", _ip, _username, _password));
+ logger.debug(String.format("Trying to connect to DHCP
server(IP=%1$s, username=%2$s, password=%3$s)", _ip, _username, "******"));
Review Comment:
```suggestion
logger.debug(String.format("Trying to connect to DHCP
server(IP=%1$s, username=%2$s, password=******", _ip, _username));
```
##########
plugins/hypervisors/baremetal/src/main/java/com/cloud/baremetal/networkservice/BaremetalDnsmasqResource.java:
##########
@@ -46,10 +46,10 @@ public boolean configure(String name, Map<String, Object>
params) throws Configu
com.trilead.ssh2.Connection sshConnection = null;
try {
super.configure(name, params);
- logger.debug(String.format("Trying to connect to DHCP
server(IP=%1$s, username=%2$s, password=%3$s)", _ip, _username, _password));
+ logger.debug(String.format("Trying to connect to DHCP
server(IP=%1$s, username=%2$s, password=%3$s)", _ip, _username, "******"));
sshConnection = SSHCmdHelper.acquireAuthorizedConnection(_ip,
_username, _password);
if (sshConnection == null) {
- throw new ConfigurationException(String.format("Cannot connect
to DHCP server(IP=%1$s, username=%2$s, password=%3$s", _ip, _username,
_password));
+ throw new ConfigurationException(String.format("Cannot connect
to DHCP server(IP=%1$s, username=%2$s, password=%3$s", _ip, _username,
"******"));
Review Comment:
```suggestion
throw new ConfigurationException(String.format("Cannot
connect to DHCP server(IP=%1$s, username=%2$s, password=******", _ip,
_username));
```
##########
plugins/hypervisors/baremetal/src/main/java/com/cloud/baremetal/networkservice/BaremetalKickStartPxeResource.java:
##########
@@ -131,7 +131,7 @@ private Answer execute(VmDataCommand cmd) {
sshConnection.connect(null, 60000, 60000);
if (!sshConnection.authenticateWithPassword(_username, _password))
{
logger.debug("SSH Failed to authenticate");
- throw new ConfigurationException(String.format("Cannot connect
to PING PXE server(IP=%1$s, username=%2$s, password=%3$s", _ip, _username,
_password));
+ throw new ConfigurationException(String.format("Cannot connect
to PING PXE server(IP=%1$s, username=%2$s, password=%3$s", _ip, _username,
"******"));
Review Comment:
```suggestion
throw new ConfigurationException(String.format("Cannot
connect to PING PXE server(IP=%1$s, username=%2$s, password=******", _ip,
_username));
```
##########
plugins/hypervisors/baremetal/src/main/java/com/cloud/baremetal/networkservice/BaremetalPingPxeResource.java:
##########
@@ -237,7 +237,7 @@ private Answer execute(VmDataCommand cmd) {
sshConnection.connect(null, 60000, 60000);
if (!sshConnection.authenticateWithPassword(_username, _password))
{
logger.debug("SSH Failed to authenticate");
- throw new ConfigurationException(String.format("Cannot connect
to PING PXE server(IP=%1$s, username=%2$s, password=%3$s", _ip, _username,
_password));
+ throw new ConfigurationException(String.format("Cannot connect
to PING PXE server(IP=%1$s, username=%2$s, password=%3$s", _ip, _username,
"******"));
Review Comment:
```suggestion
throw new ConfigurationException(String.format("Cannot
connect to PING PXE server(IP=%1$s, username=%2$s, password=******", _ip,
_username));
```
##########
engine/schema/src/main/java/com/cloud/upgrade/DatabaseCreator.java:
##########
@@ -99,7 +99,7 @@ private static void initDB(String dbPropsFile, String
rootPassword, String[] dat
String username =
dbProperties.getProperty(String.format("db.%s.username", database));
String password =
dbProperties.getProperty(String.format("db.%s.password", database));
String dbName =
dbProperties.getProperty(String.format("db.%s.name", database));
- System.out.println(String.format("========> Initializing
database=%s with host=%s port=%s username=%s password=%s", dbName, host, port,
username, password));
+ System.out.println(String.format("========> Initializing
database=%s with host=%s port=%s username=%s password=%s", dbName, host, port,
username, "******"));
Review Comment:
```suggestion
System.out.println(String.format("========> Initializing
database=%s with host=%s port=%s username=%s password=******", dbName, host,
port, username));
```
##########
plugins/hypervisors/baremetal/src/main/java/com/cloud/baremetal/networkservice/BaremetalPingPxeResource.java:
##########
@@ -179,7 +179,7 @@ protected Answer execute(PrepareCreateTemplateCommand cmd) {
sshConnection.connect(null, 60000, 60000);
if (!sshConnection.authenticateWithPassword(_username, _password))
{
logger.debug("SSH Failed to authenticate");
- throw new ConfigurationException(String.format("Cannot connect
to PING PXE server(IP=%1$s, username=%2$s, password=%3$s", _ip, _username,
_password));
+ throw new ConfigurationException(String.format("Cannot connect
to PING PXE server(IP=%1$s, username=%2$s, password=%3$s", _ip, _username,
"******"));
Review Comment:
```suggestion
throw new ConfigurationException(String.format("Cannot
connect to PING PXE server(IP=%1$s, username=%2$s, password=******", _ip,
_username));
```
##########
agent/src/main/java/com/cloud/agent/resource/consoleproxy/ConsoleProxyResource.java:
##########
@@ -331,7 +331,7 @@ private void launchConsoleProxy(final byte[] ksBits, final
String ksPassword, fi
final Object resource = this;
logger.info("Building class loader for
com.cloud.consoleproxy.ConsoleProxy");
if (consoleProxyMain == null) {
- logger.info("Running com.cloud.consoleproxy.ConsoleProxy with
encryptor password={}", encryptorPassword);
+ logger.info("Running com.cloud.consoleproxy.ConsoleProxy with
encryptor password={}", "******");
Review Comment:
```suggestion
logger.info("Running com.cloud.consoleproxy.ConsoleProxy with
encryptor password=******");
```
##########
utils/src/main/java/com/cloud/utils/UriUtils.java:
##########
@@ -500,8 +500,10 @@ public static InputStream getInputStreamFromUrl(String
url, String user, String
if ((user != null) && (password != null)) {
httpclient.getParams().setAuthenticationPreemptive(true);
Credentials defaultcreds = new
UsernamePasswordCredentials(user, password);
- httpclient.getState().setCredentials(new
AuthScope(hostAndPort.first(), hostAndPort.second(), AuthScope.ANY_REALM),
defaultcreds);
- LOGGER.info("Added username=" + user + ", password=" +
password + "for host " + hostAndPort.first() + ":" + hostAndPort.second());
+ httpclient.getState().setCredentials(
+ new AuthScope(hostAndPort.first(),
hostAndPort.second(), AuthScope.ANY_REALM), defaultcreds);
+ LOGGER.info("Added username=" + user + ", password=****** " +
"for host " + hostAndPort.first() + ":"
+ + hostAndPort.second());
Review Comment:
```suggestion
LOGGER.info("Added username={}, password=****** for host
{}:{}"
, user
, hostAndPort.first()
, hostAndPort.second());
```
##########
plugins/hypervisors/baremetal/src/main/java/com/cloud/baremetal/networkservice/BaremetalPingPxeResource.java:
##########
@@ -151,7 +151,7 @@ protected PreparePxeServerAnswer
execute(PreparePxeServerCommand cmd) {
sshConnection.connect(null, 60000, 60000);
if (!sshConnection.authenticateWithPassword(_username, _password))
{
logger.debug("SSH Failed to authenticate");
- throw new ConfigurationException(String.format("Cannot connect
to PING PXE server(IP=%1$s, username=%2$s, password=%3$s", _ip, _username,
_password));
+ throw new ConfigurationException(String.format("Cannot connect
to PING PXE server(IP=%1$s, username=%2$s, password=%3$s", _ip, _username,
"******"));
Review Comment:
```suggestion
throw new ConfigurationException(String.format("Cannot
connect to PING PXE server(IP=%1$s, username=%2$s, password=******", _ip,
_username));
```
##########
plugins/hypervisors/baremetal/src/main/java/com/cloud/baremetal/networkservice/BaremetalKickStartPxeResource.java:
##########
@@ -167,7 +167,7 @@ private Answer execute(PrepareKickstartPxeServerCommand
cmd) {
sshConnection.connect(null, 60000, 60000);
if (!sshConnection.authenticateWithPassword(_username, _password))
{
logger.debug("SSH Failed to authenticate");
- throw new ConfigurationException(String.format("Cannot connect
to PING PXE server(IP=%1$s, username=%2$s, password=%3$s", _ip, _username,
_password));
+ throw new ConfigurationException(String.format("Cannot connect
to PING PXE server(IP=%1$s, username=%2$s, password=%3$s", _ip, _username,
"******"));
Review Comment:
```suggestion
throw new ConfigurationException(String.format("Cannot
connect to PING PXE server(IP=%1$s, username=%2$s, password=******", _ip,
_username));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
