YLChen-007 commented on code in PR #12024:
URL: https://github.com/apache/cloudstack/pull/12024#discussion_r2516486488
##########
utils/src/main/java/com/cloud/utils/script/Script.java:
##########
@@ -437,11 +469,8 @@ public String executeIgnoreExitValue(OutputInterpreter
interpreter, int exitValu
Task timedoutTask = new Task(log, ir);
timedoutTask.run();
- if (!_passwordCommand) {
- _logger.warn(String.format("Timed out: %s. Output is:
%s", buildCommandLine(command), timedoutTask.getResult()));
- } else {
- _logger.warn(String.format("Timed out: %s",
buildCommandLine(command)));
- }
+ _logger.warn(String.format("Timed out: %s. Output is: %s",
commandLine,
+ timedoutTask.getResult()));
Review Comment:
The _passwordCommand flag set "true" at Line 181, and the "obscureParam"
also set "true". So the sensitive information specifing by "-y" or "-z" is
masked in Line 172. So I think we should remove the _passwordCommand flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
