Copilot commented on code in PR #12156:
URL: https://github.com/apache/cloudstack/pull/12156#discussion_r2569002786
##########
ui/src/components/view/DetailsTab.vue:
##########
@@ -64,7 +64,7 @@
</div>
<div v-else-if="$route.meta.name === 'backup' && item === 'volumes'">
<div v-for="(volume, idx) in JSON.parse(dataResource[item])"
:key="idx">
- <router-link v-if="!dataResource['vmbackupofferingremoved']"
:to="{ path: '/volume/' + volume.uuid }">{{ volume.type }} - {{ volume.path
}}</router-link>
+ <router-link v-if="!dataResource['vmbackupofferingremoved']"
:to="{ path: '/volume/' + volume.uuid }">{{ volume.type }} - {{ volume.uuid
}}</router-link>
<span v-else>{{ volume.type }} - {{ volume.path }}</span> ({{
parseFloat(volume.size / (1024.0 * 1024.0 * 1024.0)).toFixed(1) }} GB)
Review Comment:
The fallback case on line 68 still displays `volume.path` instead of
`volume.uuid`, which is inconsistent with the change on line 67. For
consistency with the PR's goal of showing volume UUIDs instead of backup file
storage UUIDs, this should also be changed to `volume.uuid`.
```suggestion
<span v-else>{{ volume.type }} - {{ volume.uuid }}</span> ({{
parseFloat(volume.size / (1024.0 * 1024.0 * 1024.0)).toFixed(1) }} GB)
```
```suggestion
<span v-else>{{ volume.type }} - {{ volume.uuid }}</span> ({{
parseFloat(volume.size / (1024.0 * 1024.0 * 1024.0)).toFixed(1) }} GB)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
