DaanHoogland commented on code in PR #12153:
URL: https://github.com/apache/cloudstack/pull/12153#discussion_r2570994956


##########
agent/src/main/java/com/cloud/agent/Agent.java:
##########
@@ -1228,7 +1228,14 @@ public void doTask(final Task task) throws 
TaskExecutionException {
                     logger.error("Error parsing task", e);
                 }
             } else if (task.getType() == Task.Type.DISCONNECT) {
-                logger.debug("Executing disconnect task - {}", () -> 
getLinkLog(task.getLink()));
+                try {
+                    // an issue has been found if reconnect immediately after 
disconnecting. please refer to https://github.com/apache/cloudstack/issues/8517

Review Comment:
   ```suggestion
                       // an issue has been found if reconnect immediately 
after disconnecting.
   ```
   
   I think we can refer a github issue in a PR but not in code. We may not be 
on github forever.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to