GaOrtiga commented on code in PR #8934:
URL: https://github.com/apache/cloudstack/pull/8934#discussion_r2578068107
##########
engine/components-api/src/main/java/com/cloud/resource/ResourceManager.java:
##########
@@ -61,6 +61,11 @@ public interface ResourceManager extends ResourceService,
Configurable {
+ "To force-stop VMs, choose 'ForceStop' strategy",
true, ConfigKey.Scope.Global, null, null, null, null, null,
ConfigKey.Kind.Select, "Error,Migration,ForceStop");
+ ConfigKey<String> SystemVMDefaultHypervisor = new
ConfigKey<String>(String.class,
+ "system.vm.default.hypervisor", "Advanced", "Any", "Hypervisor
type used to create System VMs. Valid values are: XenServer, KVM, VMware,
Hyperv, VirtualBox, " +
+ "Parralels, BareMetal, Ovm, LXC, Any", true,
ConfigKey.Scope.Global, null, null, null, null, null, ConfigKey.Kind.Select,
"XenServer, KVM, VMware, Hyperv, " +
+ "VirtualBox, Parralels, BareMetal, Ovm, LXC, Any");
Review Comment:
Hello, @weizhouapache
Sorry for the long hiatus.
Yes, the original `NULL` value acts the same as `None`, which is the same as
`Any`, since the option `Any` returns the `HypervisorType.None` type.
On ResourceManagerImpl.java#getDefaultHypervisor(), there is a validation
for whether the Default hypervisor matches the hypervisor of any template, and
if this is not the case, `HypervisorType.None` is returned. Since `Any` will
not match any template available, `HypervisorType.None` will always be
returned, maintaining the current behaviour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
