weizhouapache commented on code in PR #8934:
URL: https://github.com/apache/cloudstack/pull/8934#discussion_r2580161246
##########
engine/components-api/src/main/java/com/cloud/resource/ResourceManager.java:
##########
@@ -61,6 +61,11 @@ public interface ResourceManager extends ResourceService,
Configurable {
+ "To force-stop VMs, choose 'ForceStop' strategy",
true, ConfigKey.Scope.Global, null, null, null, null, null,
ConfigKey.Kind.Select, "Error,Migration,ForceStop");
+ ConfigKey<String> SystemVMDefaultHypervisor = new
ConfigKey<String>(String.class,
+ "system.vm.default.hypervisor", "Advanced", "Any", "Hypervisor
type used to create System VMs. Valid values are: XenServer, KVM, VMware,
Hyperv, VirtualBox, " +
+ "Parralels, BareMetal, Ovm, LXC, Any", true,
ConfigKey.Scope.Global, null, null, null, null, null, ConfigKey.Kind.Select,
"XenServer, KVM, VMware, Hyperv, " +
+ "VirtualBox, Parralels, BareMetal, Ovm, LXC, Any");
Review Comment:
I did not check in details , it seems None/Any has different process
```
@Override
public HypervisorType getAvailableHypervisor(final long zoneId) {
HypervisorType defaultHype = getDefaultHypervisor(zoneId);
if (defaultHype == HypervisorType.None) {
final List<HypervisorType> supportedHypes =
getSupportedHypervisorTypes(zoneId, false, null);
if (!supportedHypes.isEmpty()) {
Collections.shuffle(supportedHypes);
defaultHype = supportedHypes.get(0);
}
}
if (defaultHype == HypervisorType.None) {
defaultHype = HypervisorType.Any;
}
return defaultHype;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
