GutoVeronezi commented on code in PR #8728:
URL: https://github.com/apache/cloudstack/pull/8728#discussion_r2625142139
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/host/UpdateHostCmd.java:
##########
@@ -147,7 +147,7 @@ public void execute() {
this.setResponseObject(hostResponse);
} catch (Exception e) {
Host host = _entityMgr.findById(Host.class, getId());
- logger.debug("Failed to update host: {} with id {}", host,
getId(), e);
+ logger.debug("Failed to update {}", host, e);
Review Comment:
Examples without the changes:
```
2025-12-16 17:16:50,237 DEBUG [o.a.c.a.c.a.h.UpdateHostCmd]
(qtp2038105753-23:[ctx-5063625c, ctx-1ffc3504]) (logid:8d27d46e) Failed to
update host: null with id 20
com.cloud.exception.InvalidParameterValueException: Host with id 20 doesn't
exist
```
```
2025-12-16 17:22:17,341 DEBUG [o.a.c.a.c.a.h.UpdateHostCmd]
(qtp2038105753-23:[ctx-9cf64008, ctx-8c4ea9d8]) (logid:8b67772c) Failed to
update host: Host
{"id":2,"name":"v-1-VM","type":"ConsoleProxy","uuid":"8d403878-97ec-432c-b7b2-48dc4fc1ec34"}
with id 2 com.cloud.exception.InvalidParameterValueException: Please specify a
valid guest OS category.
```
---
Examples with the change:
```
2025-12-16 19:11:05,173 DEBUG [o.a.c.a.c.a.h.UpdateHostCmd]
(qtp2038105753-381:[ctx-ecf1c194, ctx-ae65f974]) (logid:bf96b30d) Failed to
update null com.cloud.exception.InvalidParameterValueException: Host with id 20
doesn't exist
```
```
2025-12-16 19:09:49,348 DEBUG [o.a.c.a.c.a.h.UpdateHostCmd]
(qtp2038105753-28:[ctx-0e6a09ab, ctx-9a5fdab5]) (logid:43ca681c) Failed to
update Host
{"id":2,"name":"v-1-VM","type":"ConsoleProxy","uuid":"8d403878-97ec-432c-b7b2-48dc4fc1ec34"}
com.cloud.exception.InvalidParameterValueException: Please specify a valid
guest OS category.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
