GutoVeronezi commented on code in PR #8728:
URL: https://github.com/apache/cloudstack/pull/8728#discussion_r2625143704
##########
api/src/main/java/org/apache/cloudstack/api/command/user/network/CreateNetworkACLListCmd.java:
##########
@@ -128,7 +128,7 @@ public long getEntityOwnerId() {
} else {
account = CallContext.current().getCallingAccount();
if (!Account.Type.ADMIN.equals(account.getType())) {
- logger.warn(String.format("Only Root Admin can create global
ACLs. Account [%s] cannot create any global ACL.", account));
+ logger.error("Only Root Admin can create global ACLs. {}
cannot create any global ACL.", account);
Review Comment:
Example without the changes:
```
2025-12-16 17:26:41,858 WARN [o.a.c.a.c.u.n.CreateNetworkACLListCmd]
(qtp2038105753-22:[ctx-a568fe7b, ctx-db4621bd]) (logid:ef24b1da) Only Root
Admin can create global ACLs. Account [Account
[{"accountName":"test","id":4,"uuid":"991ecfb6-b09a-4abf-9488-7e3d47b175fe"}]]
cannot create any global ACL.
```
---
Example with the changes:
```
2025-12-16 19:04:43,593 ERROR [o.a.c.a.c.u.n.CreateNetworkACLListCmd]
(qtp2038105753-27:[ctx-37d7f311, ctx-ddfdecd2]) (logid:62794f63) Only Root
Admin can create global ACLs. Account
[{"accountName":"test","id":4,"uuid":"991ecfb6-b09a-4abf-9488-7e3d47b175fe"}]
cannot create any global ACL.
```
##########
api/src/main/java/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotFromVMSnapshotCmd.java:
##########
@@ -165,7 +165,7 @@ public void create() throws ResourceAllocationException {
@Override
public void execute() {
VMSnapshot vmSnapshot =
_vmSnapshotService.getVMSnapshotById(getVMSnapshotId());
- logger.info("CreateSnapshotFromVMSnapshotCmd with vm snapshot {} with
id {} and snapshot [id: {}, uuid: {}]", vmSnapshot, getVMSnapshotId(),
getEntityId(), getEntityUuid());
+ logger.info("CreateSnapshotFromVMSnapshotCmd with {} and snapshot [id:
{}, uuid: {}]", vmSnapshot, getEntityId(), getEntityUuid());
Review Comment:
Example without the changes:
```
2025-12-16 18:57:48,937 INFO
[o.a.c.a.c.u.s.CreateSnapshotFromVMSnapshotCmd]
(API-Job-Executor-5:[ctx-f3a19882, job-75, ctx-5649bc6b]) (logid:874d335b)
CreateSnapshotFromVMSnapshotCmd with vm snapshot VMSnapshot
{"id":2,"name":"i-2-3-VM_VS_20251216215732","uuid":"2038367a-3f0a-4931-bcd7-9faf927f75d4","vmId":3}
with id 2 and snapshot [id: 2, uuid: 21d9aed7-65d3-47e3-a75c-fd96b9c97422]
```
---
Example with the changes:
```
2025-12-16 19:08:50,057 INFO
[o.a.c.a.c.u.s.CreateSnapshotFromVMSnapshotCmd]
(API-Job-Executor-1:[ctx-7cf2cd28, job-78, ctx-088f4cdf]) (logid:4db7c046)
CreateSnapshotFromVMSnapshotCmd with VMSnapshot
{"id":2,"name":"i-2-3-VM_VS_20251216215732","uuid":"2038367a-3f0a-4931-bcd7-9faf927f75d4","vmId":3}
and snapshot [id: 3, uuid: 1a89a444-b5f3-4ca2-9463-e32c89530aa9]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
