sureshanaparti commented on code in PR #7405:
URL: https://github.com/apache/cloudstack/pull/7405#discussion_r2671488614
##########
server/src/main/java/com/cloud/network/NetworkServiceImpl.java:
##########
@@ -2986,8 +2989,13 @@ public boolean restartNetwork(RestartNetworkCmd cmd)
throws ConcurrentOperationE
throwInvalidIdException("Cannot restart a VPC tier with cleanup,
please restart the whole VPC.", network.getUuid(), "network tier");
}
boolean makeRedundant = cmd.getMakeRedundant();
- boolean livePatch = cmd.getLivePatch();
User callerUser =
_accountMgr.getActiveUser(CallContext.current().getCallingUserId());
+ if (makeRedundant &&
!_accountMgr.isRootAdmin(callerUser.getAccountId()) &&
!AllowUsersToMakeNetworksRedundant.value() ) {
+ throw new InvalidParameterValueException(String.format("Could not
make network redundant as calling user is not Root Admin and [%s] is set to
false.",
Review Comment:
```suggestion
throw new InvalidParameterValueException("Could not make the
network redundant. Please contact administrator.");
```
##########
server/src/main/java/com/cloud/network/NetworkServiceImpl.java:
##########
@@ -2986,8 +2989,13 @@ public boolean restartNetwork(RestartNetworkCmd cmd)
throws ConcurrentOperationE
throwInvalidIdException("Cannot restart a VPC tier with cleanup,
please restart the whole VPC.", network.getUuid(), "network tier");
}
boolean makeRedundant = cmd.getMakeRedundant();
- boolean livePatch = cmd.getLivePatch();
User callerUser =
_accountMgr.getActiveUser(CallContext.current().getCallingUserId());
+ if (makeRedundant &&
!_accountMgr.isRootAdmin(callerUser.getAccountId()) &&
!AllowUsersToMakeNetworksRedundant.value() ) {
+ throw new InvalidParameterValueException(String.format("Could not
make network redundant as calling user is not Root Admin and [%s] is set to
false.",
+ AllowUsersToMakeNetworksRedundant.key()));
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
