Pearl1594 commented on code in PR #12409:
URL: https://github.com/apache/cloudstack/pull/12409#discussion_r2685898839


##########
framework/jobs/src/main/java/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java:
##########
@@ -969,6 +969,13 @@ public void reallyRun() {
                     }
 
                     logger.trace("End cleanup expired async-jobs");
+
+                    // 3) Cleanup orphaned networks stuck in Implementing 
state without async jobs
+                    try {
+                        cleanupOrphanedNetworks();
+                    } catch (Throwable e) {
+                        logger.error("Unexpected exception when trying to 
cleanup orphaned networks", e);
+                    }

Review Comment:
   Just following how the other cases are handled. Also, we will be able to 
know which operation really failed in this block



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to