Re: [PR] UI Add comprehensive domain deletion confirmation dialog (Feature Request #11497) [cloudstack]

[via GitHub]

Imvedansh commented on PR #12380:
URL: https://github.com/apache/cloudstack/pull/12380#issuecomment-3748640026

   > looks nice but one issue: <img alt="Screenshot 2026-01-13 at 20 15 15" 
width="412" height="239" 
src="https://private-user-images.githubusercontent.com/2486961/535267632-2b859c73-c923-4a68-8f17-754657847951.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjgzNzk4MTQsIm5iZiI6MTc2ODM3OTUxNCwicGF0aCI6Ii8yNDg2OTYxLzUzNTI2NzYzMi0yYjg1OWM3My1jOTIzLTRhNjgtOGYxNy03NTQ2NTc4NDc5NTEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI2MDExNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNjAxMTRUMDgzMTU0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YjhjNTQ0N2FkNjdkMWFlNGNkY2Y1YjFiOWZmMWQ4YzhmOGM3ZmRhOTZhOWFmZDg1YmJiNTg2YjhlYWRiM2IzOSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.UnCP2aQcibdgv5EtOH-eQVDJT9VtJ1ArItzesdbme2k";>
 I think you mean to delete users with the domain, don’t you?
   > 
   > deleting an empty domain works.
   
   Thanks Daan for checking this out
   Let me clarify it ,I spend quite time to understand the architecture last 
when picked it.
   
   Deleting an empty domain works as expected. When a domain contains accounts, 
users, or sub-domains, the deletion fails because the CloudStack backend does 
not allow cascading deletion of users or accounts during domain deletion, in 
order to avoid catastrophic actions. The error shown is therefore correct and 
comes from the backend async job result.
   
   The UI change in this PR does not attempt to change backend deletion 
semantics. Instead, it focuses on:
   
   Correctly handling deleteDomain as an async job .
   
   Improving user awareness by clearly showing associated accounts and 
instances before attempting deletion
   
   Providing better verbiage around domain deletion expectations, as requested 
in #11497 
   
   Previously, after an unsuccessful domain deletion, users had to manually 
navigate through accounts and instances to identify what was still associated 
with the domain, quite not cool
   
   With the current change, the UI presents the list of associated accounts and 
active/stopped instances upfront, making it easier to clean up the domain by 
deleting the related accounts first and then retrying the domain deletion.
   
   So far this is my understanding ,
   If I'm mistaken anywhere do let me know I ll be happy to work on that 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org