Imvedansh commented on PR #12380: URL: https://github.com/apache/cloudstack/pull/12380#issuecomment-3764075530
> Ok @Imvedansh , I do not care either way, but as https://cloudstack.staged.apache.org/api/apidocs-4.22/apis/deleteDomain.html states there is a `cleanup` option on the `deleteDomain` API and I kind of expected that to be used once I had ok’d the consequences. I am fine with merging like this even when this improvement can be done. Just need to add cleanup:true in domainDelete funtion. It's not much, but may need to be tested seprately for every state ,such as with account, with instance , state :stopped,state:running. What would you prefer to merge this as in condition , and I can add another PR shortly for same with proper testing. or to do all in this PR PS. Im working on what you asked as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
