vishesh92 commented on code in PR #12419:
URL: https://github.com/apache/cloudstack/pull/12419#discussion_r2693101425
##########
server/src/main/java/org/apache/cloudstack/region/gslb/GlobalLoadBalancingRulesServiceImpl.java:
##########
@@ -673,7 +673,7 @@ private boolean applyGlobalLoadBalancerRuleConfig(long
gslbRuleId, boolean revok
// set site as 'local' for the site in that zone
for (Pair<Long, Long> innerLoopZoneId : gslbSiteIds) {
SiteLoadBalancerConfig siteLb =
zoneSiteLoadbalancerMap.get(innerLoopZoneId.first());
- siteLb.setLocal(zoneId.first() == innerLoopZoneId.first());
+
siteLb.setLocal(zoneId.first().equals(innerLoopZoneId.first()));
Review Comment:
I just have one concern about changes like this is that this could cause NPE
if if `zoneId.first()` is `null` for whatever reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
