furkandogmus commented on issue #12405:
URL: https://github.com/apache/cloudstack/issues/12405#issuecomment-3754727840
Hi @abh1sar,
Thank you for testing! I understand that NAS(nfs) provider works correctly
with hot-attach.
My observation is specifically about out-of-band backup providers like Veeam
and Networker.
The NAS provider handles hot-attach on the agent side via
LibvirtRestoreBackupCommandWrapper
, which explicitly calls virsh attach-disk. However, other providers that
restore data through external APIs or SSH scripts don't have this mechanism.
After tracing the code, I noticed that:
NASBackupProvider
→ sends
RestoreBackupCommand
to agent → agent does virsh attach-disk **ok**
VeeamBackupProvider
/
NetworkerBackupProvider
→ call external API/script → return to
BackupManagerImpl
→ only DB is updated, no hypervisor notification **XXX**
So my question is: Is this expected behavior for non-NAS providers, or
should
BackupManagerImpl
(or HypervisorGuru) be responsible for triggering live-attach after the
provider completes the restore?
I propose centralizing this logic in BackupManagerImpl.java to ensure
consistent behavior across all providers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
