vishesh92 commented on code in PR #12445:
URL: https://github.com/apache/cloudstack/pull/12445#discussion_r2697452518
##########
services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java:
##########
@@ -1225,7 +1225,9 @@ public boolean
finalizeVirtualMachineProfile(VirtualMachineProfile profile, Depl
buf.append(" dns2=").append(dc.getDns2());
}
String nfsVersion = imageStoreDetailsUtil != null ?
imageStoreDetailsUtil.getNfsVersion(secStores.get(0).getId()) : null;
- buf.append(" nfsVersion=").append(nfsVersion);
+ if (nfsVersion != null) {
Review Comment:
Should we add a check for isNotBlank instead? If for some reason,
`secstorage.nfs.version` is an empty string for the image store instead of
null, this might cause errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
