DaanHoogland commented on code in PR #12452:
URL: https://github.com/apache/cloudstack/pull/12452#discussion_r2698541917
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java:
##########
@@ -1320,64 +1320,68 @@ protected boolean checkDetachSuccess(String diskPath,
Domain dm) throws LibvirtE
/**
* Attaches or detaches a disk to an instance.
- * @param conn libvirt connection
- * @param attach boolean that determines whether the device will be
attached or detached
- * @param vmName instance name
- * @param attachingDisk kvm physical disk
- * @param devId device id in instance
+ *
+ * @param conn libvirt connection
+ * @param attach boolean that determines whether the
device will be attached or detached
+ * @param vmName instance name
+ * @param attachingDisk kvm physical disk
+ * @param devId device id in instance
* @param serial
- * @param bytesReadRate bytes read rate
- * @param bytesReadRateMax bytes read rate max
- * @param bytesReadRateMaxLength bytes read rate max length
- * @param bytesWriteRate bytes write rate
- * @param bytesWriteRateMax bytes write rate amx
+ * @param bytesReadRate bytes read rate
+ * @param bytesReadRateMax bytes read rate max
+ * @param bytesReadRateMaxLength bytes read rate max length
+ * @param bytesWriteRate bytes write rate
+ * @param bytesWriteRateMax bytes write rate amx
* @param bytesWriteRateMaxLength bytes write rate max length
- * @param iopsReadRate iops read rate
- * @param iopsReadRateMax iops read rate max
- * @param iopsReadRateMaxLength iops read rate max length
- * @param iopsWriteRate iops write rate
- * @param iopsWriteRateMax iops write rate max
- * @param iopsWriteRateMaxLength iops write rate max length
- * @param cacheMode cache mode
- * @param encryptDetails encrypt details
+ * @param iopsReadRate iops read rate
+ * @param iopsReadRateMax iops read rate max
+ * @param iopsReadRateMaxLength iops read rate max length
+ * @param iopsWriteRate iops write rate
+ * @param iopsWriteRateMax iops write rate max
+ * @param iopsWriteRateMaxLength iops write rate max length
+ * @param cacheMode cache mode
+ * @param encryptDetails encrypt details
+ * @param controllerInfo
* @throws LibvirtException
* @throws InternalErrorException
*/
protected synchronized void attachOrDetachDisk(final Connect conn, final
boolean attach, final String vmName, final KVMPhysicalDisk attachingDisk, final
int devId,
final String serial, final
Long bytesReadRate, final Long bytesReadRateMax, final Long
bytesReadRateMaxLength,
final Long bytesWriteRate,
final Long bytesWriteRateMax, final Long bytesWriteRateMaxLength, final Long
iopsReadRate,
final Long iopsReadRateMax,
final Long iopsReadRateMaxLength, final Long iopsWriteRate, final Long
iopsWriteRateMax,
- final Long
iopsWriteRateMaxLength, final String cacheMode, final
DiskDef.LibvirtDiskEncryptDetails encryptDetails, Map<String, String> details)
+ final Long
iopsWriteRateMaxLength, final String cacheMode, final
DiskDef.LibvirtDiskEncryptDetails encryptDetails, Map<String, String> details,
Map<String, String> controllerInfo)
throws LibvirtException, InternalErrorException {
attachOrDetachDisk(conn, attach, vmName, attachingDisk, devId, serial,
bytesReadRate, bytesReadRateMax, bytesReadRateMaxLength,
bytesWriteRate, bytesWriteRateMax, bytesWriteRateMaxLength,
iopsReadRate, iopsReadRateMax, iopsReadRateMaxLength, iopsWriteRate,
- iopsWriteRateMax, iopsWriteRateMaxLength, cacheMode,
encryptDetails, 0l, details);
+ iopsWriteRateMax, iopsWriteRateMaxLength, cacheMode,
encryptDetails, 0l, details, controllerInfo);
}
/**
*
* Attaches or detaches a disk to an instance.
- * @param conn libvirt connection
- * @param attach boolean that determines whether the device will be
attached or detached
- * @param vmName instance name
- * @param attachingDisk kvm physical disk
- * @param devId device id in instance
+ *
Review Comment:
i think current practice is that blank lines are not desirable in javadoc
(iianm)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
