harikrishna-patnala commented on PR #12464: URL: https://github.com/apache/cloudstack/pull/12464#issuecomment-3771342160
> > @harikrishna-patnala , I don’t see any of the possible NPEs in the old code being mitigated in the new code. Am I missing something? > > This is happening during any development or when an extra column was added in the table and no reference in the VO. Here few safe checks are added for that. @DaanHoogland unfortunately I could not reproduce this now, as the column count seems to be fine in most of the cases, but I think this has caused issues in retrieving the attr object when the sql statement usage contains "SELECT *". In remaining cases where specific columns in SELECT query are used, there won't be this issue. I feel this check can be kept as we are rightly logging when attr is not found. Please let me know your thoughts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
