weizhouapache commented on code in PR #12499:
URL: https://github.com/apache/cloudstack/pull/12499#discussion_r2716507628
##########
server/src/main/java/com/cloud/template/TemplateManagerImpl.java:
##########
@@ -2172,6 +2176,11 @@ private VMTemplateVO
updateTemplateOrIso(BaseUpdateTemplateOrIsoCmd cmd) {
templateType = validateTemplateType(cmd, isAdmin,
template.isCrossZones());
if (cmd instanceof UpdateVnfTemplateCmd) {
VnfTemplateUtils.validateApiCommandParams(cmd, template);
+ UpdateVnfTemplateCmd updateCmd = (UpdateVnfTemplateCmd) cmd;
+ if (template.isDeployAsIs() &&
CollectionUtils.isNotEmpty(updateCmd.getVnfNics())) {
Review Comment:
@nvazquez
when register a deploy-as-is template, the template NICs are not available
until the template is downloaded successfully.
I think it is better that user configures VNF nics only when template NICs
are fetched from OVA template.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
