weizhouapache commented on code in PR #12499:
URL: https://github.com/apache/cloudstack/pull/12499#discussion_r2716518935
##########
api/src/main/java/org/apache/cloudstack/storage/template/VnfTemplateUtils.java:
##########
@@ -124,6 +125,9 @@ public static void validateVnfNics(List<VNF.VnfNic>
nicsList) {
public static void validateApiCommandParams(BaseCmd cmd,
VirtualMachineTemplate template) {
if (cmd instanceof RegisterVnfTemplateCmd) {
RegisterVnfTemplateCmd registerCmd = (RegisterVnfTemplateCmd) cmd;
+ if (registerCmd.isDeployAsIs() &&
CollectionUtils.isNotEmpty(registerCmd.getVnfNics())) {
+ throw new InvalidParameterValueException("VNF Template cannot
be registered with VNF nics as Template settings are read from OVA.");
+ }
Review Comment:
```suggestion
if (registerCmd.isDeployAsIs() &&
CollectionUtils.isNotEmpty(registerCmd.getVnfNics())) {
throw new InvalidParameterValueException("VNF nics cannot be
specified when register a deploy-as-is Template. Please wait until Template
settings are read from OVA.");
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
