DaanHoogland commented on code in PR #11748:
URL: https://github.com/apache/cloudstack/pull/11748#discussion_r2737097505
##########
test/integration/plugins/storpool/test_snapshot_copy_on_primary_storage.py:
##########
@@ -158,10 +162,9 @@ def test_01_take_snapshot_multi_zone(self):
"""
snapshot = Snapshot.create(self.userapiclient,
volume_id=self.volume.id, zoneids=[str(self.additional_zone.id)],
usestoragereplication=True)
+ self._cleanup.append(snapshot)
Review Comment:
but the creation does need to happen in the test?
seems strangely asymmetrical and I would have to think if my mind can handle
this… ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
