This is an automated email from the ASF dual-hosted git repository.
pearl11594 pushed a change to branch add-errorprone
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
from f3a66fd65b9 Merge branch '4.20' of
https://github.com/apache/cloudstack into add-errorprone
add 43162bfce8a Error Prone integration - Added error prone to the build
add ca9fc493c4d fix tests
add 0526416e4b8 fix copilot comments
add 666105b168a fix codespell check
add 5967128527d fix tests
add ff5902cceba fix test identified by errorprone
add f42149960e5 fix test identified by errorprone
add 4d5f8194134 fix test issues identified by errorprone
add a3f3918db94 fix issues
add b1026a226c7 revert errorprone plugin inclusion in pom
add 304a3eb4f6d fix linter
add f9ca9bef5f5 remove hardcoded hashcode
add 7e5e80ea066 Merge branch '4.20' of
https://github.com/apache/cloudstack into ghi11438-errorprone-fixes
add 58c6e23d1d9 Merge branch 'ghi11438-errorprone-fixes' of
https://github.com/apache/cloudstack into add-errorprone
No new revisions were added by this update.
Summary of changes:
.../java/com/cloud/agent/mockvm/MockVmMgr.java | 2 +-
.../admin/backup/UpdateBackupOfferingCmd.java | 2 +-
.../com/cloud/network/IsolationMethodTest.java | 2 +-
.../facade/AbstractConfigItemFacade.java | 2 +-
.../com/cloud/network/HAProxyConfigurator.java | 2 +-
.../java/com/cloud/resource/RequestWrapper.java | 2 +-
.../directdownload/DirectDownloadCommand.java | 1 -
.../com/cloud/resource/ServerResourceBaseTest.java | 23 +++----
.../java/com/cloud/agent/manager/AgentAttache.java | 6 ++
.../cloud/agent/manager/DirectAgentAttache.java | 5 ++
.../com/cloud/vm/VirtualMachineManagerImpl.java | 2 +-
.../engine/orchestration/NetworkOrchestrator.java | 2 +-
.../com/cloud/offerings/NetworkOfferingVO.java | 2 +-
.../upgrade/SystemVmTemplateRegistration.java | 59 ++++++++--------
.../cloud/upgrade/dao/DatabaseAccessObject.java | 2 +-
.../com/cloud/upgrade/dao/Upgrade41500to41510.java | 79 ++++++++++------------
.../cloud/network/as/AutoScaleVmProfileVOTest.java | 22 ++++--
.../upgrade/SystemVmTemplateRegistrationTest.java | 1 +
.../vmsnapshot/ScaleIOVMSnapshotStrategy.java | 2 +-
.../storage/endpoint/DefaultEndPointSelector.java | 8 +--
.../framework/serializer/OnwireClassRegistry.java | 2 +-
.../factory/ModuleBasedContextFactoryTest.java | 3 +-
.../cloudstack/ca/provider/RootCAProvider.java | 2 +-
.../main/java/com/cloud/ha/HypervInvestigator.java | 2 +-
.../test/HypervDirectConnectResourceTest.java | 3 +
.../kvm/resource/LibvirtComputingResource.java | 6 +-
.../kvm/storage/KVMStorageProcessor.java | 4 +-
.../kvm/storage/MultipathSCSIAdapterBase.java | 12 ++--
.../kvm/resource/LibvirtComputingResourceTest.java | 3 +
.../kvm/storage/ScaleIOStoragePoolTest.java | 2 +
.../hypervisor/ovm3/objects/ConnectionTest.java | 2 +-
.../com/cloud/hypervisor/ovm3/objects/NtpTest.java | 2 +
.../vmware/VmwareDatacenterApiUnitTest.java | 17 +++++
.../java/com/cloud/hypervisor/XenServerGuru.java | 5 +-
.../xenserver/resource/CitrixResourceBaseTest.java | 3 +
.../guru/BrocadeVcsGuestNetworkGuruTest.java | 2 -
.../network/cisco/CiscoVnmcConnectionTest.java | 3 +-
.../network/resource/CiscoVnmcResourceTest.java | 3 +
.../guru/NiciraNvpGuestNetworkGuruTest.java | 6 --
.../com/cloud/network/nicira/NiciraNvpApiIT.java | 2 -
.../cloudstack/agent/api/NsxNetworkCommand.java | 2 +-
.../AddTungstenFabricPolicyRuleCmdTest.java | 2 +
.../CreateTungstenFabricFirewallRuleCmdTest.java | 2 +
.../CreateTungstenFabricProviderCmdTest.java | 2 +
.../command/DeleteTungstenFabricTagCmdTest.java | 2 +
.../command/RemoveTungstenFabricTagCmdTest.java | 2 +
.../driver/redfish/RedfishWrapper.java | 2 +-
.../datastore/util/NexentaStorAppliance.java | 13 +++-
.../driver/StorPoolPrimaryDataStoreDriver.java | 2 +-
.../storage/motion/StorPoolDataMotionStrategy.java | 2 +-
.../cloudstack/ldap/ADLdapUserManagerImpl.java | 1 +
.../cloudstack/ldap/OpenLdapUserManagerImpl.java | 7 +-
.../ldap/LdapDirectoryServerConnectionTest.java | 3 +
.../ldap/LdapUnboundidZapdotConnectionTest.java | 3 +
.../java/com/cloud/api/doc/ApiXmlDocWriter.java | 2 +-
.../src/main/java/com/cloud/api/doc/Argument.java | 12 ++--
.../cloud/api/query/dao/TemplateJoinDaoImpl.java | 3 +-
.../configuration/ConfigurationManagerImpl.java | 2 +-
.../com/cloud/ha/HighAvailabilityManagerImpl.java | 2 +-
.../com/cloud/network/IpAddressManagerImpl.java | 2 +-
.../com/cloud/server/ManagementServerImpl.java | 2 +-
.../com/cloud/storage/VolumeApiServiceImpl.java | 2 +-
.../main/java/com/cloud/vm/UserVmManagerImpl.java | 4 +-
.../cloudstack/network/RoutedIpv4ManagerImpl.java | 8 +--
.../gslb/GlobalLoadBalancingRulesServiceImpl.java | 2 +-
.../com/cloud/api/query/QueryManagerImplTest.java | 1 +
.../ConfigurationManagerImplTest.java | 1 +
.../deploy/DeploymentPlanningManagerImplTest.java | 57 ++++++----------
.../cloud/network/as/AutoScaleManagerImplTest.java | 5 +-
.../template/HypervisorTemplateAdapterTest.java | 2 +
.../cloud/template/TemplateManagerImplTest.java | 2 +
.../java/com/cloud/user/DomainManagerImplTest.java | 7 +-
.../java/com/cloud/vm/UserVmManagerImplTest.java | 1 +
.../test/java/com/cloud/vm/UserVmManagerTest.java | 3 +
.../cloud/vm/snapshot/VMSnapshotManagerTest.java | 7 +-
.../deployment/RouterDeploymentDefinitionTest.java | 2 +-
.../rdpclient/ntlmssp/ServerNtlmsspChallenge.java | 5 +-
.../src/main/java/streamer/ByteBuffer.java | 2 +-
.../src/test/java/streamer/ByteBufferTest.java | 1 +
.../hypervisor/vmware/mo/HypervisorHostHelper.java | 8 +--
80 files changed, 280 insertions(+), 220 deletions(-)
