This is an automated email from the ASF dual-hosted git repository.
pearl11594 pushed a change to branch ghi11438-errorprone-fixes
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
from f9ca9bef5f5 remove hardcoded hashcode
add 5c1f9315ced Remove transaction from updateCapacityForHost cal (#12421)
add aba3285c3c8 [Usage] Include accounts uuid on the cloud_usage accounts
initial saving (#12420)
add f1f779a08d9 Cleanup snapshot files in datastores for Error-ed
snapshots, and some code improvements (#12347)
add 76e6de7f90e ui: fix form data double fetch/reset form data by
ownership selection (#11705)
add a4b1a27c7d2 ui: fix 404 on login after forgot password (#12448)
add 42f1e19362a Mask vncPasswd being logged in agent.log (#12404)
add 2a6ce0c8a81 Adds url kubernetes iso (#10862)
add 03d24ff851d Fix NPE on primary storage delete (#11817)
add da518e90362 CKS: Add image store validation for Kubernetes version
registration (#12418)
add cf36fb00008 Set nfsVersion in ssvm agent.properties only if it is not
null (#12445)
add 496bc0329cd Fix: Condition for aborting migration, resume paused VMs
on destination (#12331)
add 8db7cab7ba4 Storage pool monitor disconnect improvements (#12398)
add 6e5d78a8a78 Fix NPE on adding new columns in the tables (#12464)
add b5e9178078f UI: fix issues when deploy VNF applicance on network with
SG (#12436)
add cd5bb09d0d1 Fix potential leaks in executePipedCommands (#12478)
add d1eb2822d9d Remove redundant Exceptions from logs for vm schedules
(#12428)
add 6846619a6f1 Fix update network offering domainids size limitation
(#12431)
add 6a9835904cb Fix for zoneids parameters length on updateAPIs (#12440)
add bce3e54a7e4 improve error handling for template upload notifications
(#12412)
add 8db065a14eb limit iso filename to have 251 chars at max (#12430)
add c8cadcb56e5 NPE fix while deleting storage pool when pool has detached
volumes (#12451)
add 4adb7195701 Allow modification of user vm details if
user.vm.readonly.details is empty (#10456)
add 0958dfc1386 Fix: proper permissions for systemvm template
registrations on hardened systems (#12098)
add d010e9fcf29 Notify user if template upgrade is not required (#12483)
add 63bdc2b9903 Add log for null templateVO (#12406)
add 097c3a018ba ConfigDrive: use file absolute path instead of canonical
path to create ISO (#11623)
add 36edd92e480 Fix snapshot physical size after migration (#12166)
add 44793da58f2 fix Sensitive Data Exposure Through Exception Logging in
OVM Hypervis… (#12032)
add bbc23a74683 fix install path for systemvm templates when introducing
new sec storage (#11605)
add 7536516e416 add missing label text for label.aclname (#12511)
add 63c8b5fc562 api/server: support deploy-as-is template as VNF template
(#12499)
add fa3dee886ed do not add disk cache mode from an empty string (#12248)
add 5bb5af4c480 4.20: Fix unit test failure (#12520)
add f73362ae48a Fix saml bug unable to login (#10868)
add ff0cfc9148a Add ability to filter by version for listHosts and
listMgmtServers APIs (#12472)
add fce69fbfe0b VM Power state optimization (#12463)
add 0458c5328bf Consider secondary storage selectors during template
synchronization (#10956)
add b6134418eaf server: do not run dhcp and dns check if VR is not
provider (#12272)
add ca5232778da CKS: Use Zone MTUs when network is created at the time of
CKS cluster creation (#12228)
add af9d68630f7 Initialize template status='Processing' (#11970)
add c0b5358d8eb fix Host Password Exposed in Command-Line Logging (#12016)
add dd0b863e225 sensitive information leak to log (#12018)
add 70d4c9d1baa Consider secondary storage selectors during cold volume
migration (#10957)
add 0dcbe57a478 Fix that Sensitive information logged in
SshHelper.sshExecute method (#12026)
add 6932cacabc1 Allow copy of templates from secondary storages of other
zone when adding a new secondary storage (#12296)
add ff7ec0cd229 Update alert id for VR public and private interface
(#12527)
add 83ce0067b82 Update the snapshot physical size for the primary storage
resource after snapshot creation and during resource count recalculation
(#12481)
add 35e6d7c5ba8 fix that log sensitive infomation in cmd of script (#12024)
add 95de88a8ffe Usage server should takeover immediately if the other
Usage server has been stopped gracefully (#12507)
add 1300fc5e91a Fix keyword parameter filtering in listBackupOfferings API
(#12540)
add 243872a7710 Use infinite scroll select (#11991)
add b7fc7179fca Add batch deletion support to `removeRawUsageRecords`
(#12522)
add 664f76c7e4b Fix KvmSshToAgentEnabled setting description and make it
dynamic (#12533)
add 26b57655ece Deployment plan fixes for VM with last host, and last host
in maintenance (#12062)
add 6ba5e082217 Linstor: support live migration from other primary storage
(#12532)
add 3ba5c2b610f Fix logs mismatch between Network GC wait and interval
(#10776)
add aef3df75771 server: pass network label of physical network when plug
nic for private gateway on hypervisor (#11846)
add 7d52cd0e43a Fix calculation of the next time that Usage will execute
in `removeRawUsageRecords` (#12518)
add 0e94f7d7717 UI: Show applied search filters (#9520)
add a6ccde44c4b kvm: honour disk controller for vm during attach volume
(#12452)
add 7e5e80ea066 Merge branch '4.20' of
https://github.com/apache/cloudstack into ghi11438-errorprone-fixes
No new revisions were added by this update.
Summary of changes:
.../consoleproxy/ConsoleProxyResource.java | 2 +-
.../java/com/cloud/network/NetworkService.java | 4 +
.../org/apache/cloudstack/alert/AlertService.java | 4 +-
.../org/apache/cloudstack/api/ApiConstants.java | 1 +
.../cloudstack/api/BaseUpdateTemplateOrIsoCmd.java | 2 +-
.../command/admin/host/AddSecondaryStorageCmd.java | 24 +-
.../api/command/admin/host/ListHostsCmd.java | 7 +
.../api/command/admin/management/ListMgmtsCmd.java | 8 +
.../admin/network/UpdateNetworkOfferingCmd.java | 1 +
.../admin/offering/UpdateDiskOfferingCmd.java | 1 +
.../admin/offering/UpdateServiceOfferingCmd.java | 1 +
.../command/admin/vpc/UpdateVPCOfferingCmd.java | 1 +
.../api/command/user/iso/RegisterIsoCmd.java | 2 +-
.../command/user/snapshot/CreateSnapshotCmd.java | 3 +-
.../api/command/user/vm/DeployVnfApplianceCmd.java | 2 +-
.../org/apache/cloudstack/query/QueryService.java | 2 +-
.../storage/template/VnfTemplateManager.java | 4 +-
.../storage/template/VnfTemplateUtils.java | 18 +
.../service/StorageOrchestrationService.java | 3 +-
.../subsystem/api/storage/SnapshotDataFactory.java | 2 +
.../subsystem/api/storage/TemplateService.java | 4 +-
.../main/java/com/cloud/alert/AlertManager.java | 1 -
.../java/com/cloud/resource/ResourceManager.java | 4 +-
.../java/com/cloud/storage/StorageManager.java | 5 +-
.../java/com/cloud/template/TemplateManager.java | 2 +
.../cloud/vm/VirtualMachinePowerStateSyncImpl.java | 6 +-
.../engine/orchestration/NetworkOrchestrator.java | 9 +-
.../engine/orchestration/StorageOrchestrator.java | 45 +-
.../dao/PhysicalNetworkTrafficTypeDaoImpl.java | 4 +-
.../java/com/cloud/storage/dao/SnapshotDao.java | 2 +
.../com/cloud/storage/dao/SnapshotDaoImpl.java | 7 +
.../main/java/com/cloud/storage/dao/VolumeDao.java | 6 +-
.../java/com/cloud/storage/dao/VolumeDaoImpl.java | 6 +-
.../com/cloud/upgrade/DatabaseUpgradeChecker.java | 2 +
...grade441to442.java => Upgrade42020to42030.java} | 14 +-
.../main/java/com/cloud/usage/dao/UsageDao.java | 2 +-
.../java/com/cloud/usage/dao/UsageDaoImpl.java | 54 +-
.../main/java/com/cloud/usage/dao/UsageJobDao.java | 2 +
.../java/com/cloud/usage/dao/UsageJobDaoImpl.java | 3 +-
.../storage/datastore/db/SnapshotDataStoreDao.java | 16 +
.../datastore/db/SnapshotDataStoreDaoImpl.java | 36 +-
.../vm/schedule/dao/VMScheduledJobDao.java | 2 +
.../vm/schedule/dao/VMScheduledJobDaoImpl.java | 15 +
...to41400-cleanup.sql => schema-42020to42030.sql} | 12 +-
.../storage/configdrive/ConfigDriveBuilder.java | 4 +-
.../configdrive/ConfigDriveBuilderTest.java | 12 +-
.../storage/motion/AncientDataMotionStrategy.java | 13 +-
.../storage/image/SecondaryStorageServiceImpl.java | 2 +-
.../storage/image/TemplateDataFactoryImpl.java | 3 +
.../storage/image/TemplateServiceImpl.java | 201 ++++++--
.../storage/image/TemplateServiceImplTest.java | 226 +++++++--
.../cloudstack/storage/test/SnapshotTest.java | 2 +-
.../apache/cloudstack/storage/test/VolumeTest.java | 2 +-
.../cloudstack/storage/test/VolumeTestVmware.java | 2 +-
.../storage/snapshot/DefaultSnapshotStrategy.java | 4 +-
.../storage/snapshot/SnapshotDataFactoryImpl.java | 22 +-
.../storage/snapshot/SnapshotServiceImpl.java | 9 +-
.../snapshot/StorageSystemSnapshotStrategy.java | 1 -
.../datastore/ObjectInDataStoreManagerImpl.java | 3 +
.../storage/datastore/PrimaryDataStoreImpl.java | 2 +-
.../storage/volume/VolumeServiceImpl.java | 2 +-
.../cloudstack/framework/config/ConfigKey.java | 28 +-
.../src/main/java/com/cloud/utils/db/Filter.java | 3 +-
.../java/com/cloud/utils/db/GenericDaoBase.java | 19 +-
packaging/el8/cloud.spec | 2 +-
.../apache/cloudstack/sioc/SiocManagerImpl.java | 2 +-
.../networkservice/BaremetalDnsmasqResource.java | 4 +-
.../BaremetalKickStartPxeResource.java | 6 +-
.../networkservice/BaremetalPingPxeResource.java | 10 +-
.../hypervisor/kvm/resource/BridgeVifDriver.java | 2 +-
.../kvm/resource/LibvirtComputingResource.java | 11 +-
.../kvm/resource/LibvirtDomainXMLParser.java | 4 +-
.../hypervisor/kvm/resource/LibvirtVMDef.java | 9 +
.../wrapper/LibvirtMigrateCommandWrapper.java | 70 ++-
.../wrapper/LibvirtStartCommandWrapper.java | 5 +-
.../LibvirtUpdateHostPasswordCommandWrapper.java | 3 +-
.../kvm/storage/KVMStorageProcessor.java | 121 +++--
.../wrapper/LibvirtMigrateCommandWrapperTest.java | 26 +-
.../com/cloud/ovm/hypervisor/OvmResourceBase.java | 2 +-
.../CitrixUpdateHostPasswordCommandWrapper.java | 4 +-
.../cluster/KubernetesClusterManagerImpl.java | 7 +-
.../version/KubernetesVersionManagerImpl.java | 52 +-
.../KubernetesSupportedVersionResponse.java | 12 +
.../version/KubernetesVersionManagerImplTest.java | 78 ++-
.../version/KubernetesVersionServiceTest.java | 99 +++-
.../driver/DateraPrimaryDataStoreDriver.java | 2 +-
.../datastore/provider/DateraHostListener.java | 4 +-
plugins/storage/volume/linstor/CHANGELOG.md | 6 +
.../driver/LinstorPrimaryDataStoreDriverImpl.java | 316 +-----------
.../storage/datastore/util/LinstorUtil.java | 293 ++++++++++-
.../storage/motion/LinstorDataMotionStrategy.java | 437 ++++++++++++++++
.../spring-storage-volume-linstor-context.xml | 2 +
.../LinstorPrimaryDataStoreDriverImplTest.java | 7 +-
.../driver/SolidFirePrimaryDataStoreDriver.java | 2 +-
.../datastore/provider/SolidFireHostListener.java | 4 +-
.../driver/StorPoolPrimaryDataStoreDriver.java | 2 +-
.../storage/datastore/util/StorPoolHelper.java | 2 +-
.../storage/snapshot/StorPoolSnapshotStrategy.java | 4 +-
.../apache/cloudstack/saml/SAML2AuthManager.java | 3 +
.../cloudstack/saml/SAML2AuthManagerImpl.java | 9 +-
scripts/storage/secondary/cloud-install-sys-tmplt | 1 +
scripts/storage/secondary/setup-sysvm-tmplt | 1 +
.../java/com/cloud/alert/AlertManagerImpl.java | 9 +-
.../java/com/cloud/api/query/QueryManagerImpl.java | 16 +
.../cloud/api/query/dao/TemplateJoinDaoImpl.java | 79 +--
.../configuration/ConfigurationManagerImpl.java | 2 +-
.../deploy/DeploymentPlanningManagerImpl.java | 80 +--
.../main/java/com/cloud/event/AlertGenerator.java | 5 +-
.../com/cloud/ha/HighAvailabilityManagerImpl.java | 4 +-
.../java/com/cloud/network/NetworkModelImpl.java | 6 +-
.../java/com/cloud/network/NetworkServiceImpl.java | 12 +
.../router/VirtualNetworkApplianceManagerImpl.java | 6 +-
.../com/cloud/resource/ResourceManagerImpl.java | 9 +-
.../resourcelimit/ResourceLimitManagerImpl.java | 10 +-
.../main/java/com/cloud/server/StatsCollector.java | 2 +-
.../com/cloud/storage/ImageStoreDetailsUtil.java | 11 +
.../java/com/cloud/storage/StorageManagerImpl.java | 119 +++--
.../cloud/storage/StoragePoolAutomationImpl.java | 2 +-
.../cloud/storage/listener/StoragePoolMonitor.java | 28 +-
.../storage/snapshot/SnapshotManagerImpl.java | 61 +--
.../cloud/template/HypervisorTemplateAdapter.java | 15 +-
.../com/cloud/template/TemplateManagerImpl.java | 34 +-
.../java/com/cloud/usage/UsageServiceImpl.java | 61 +--
.../main/java/com/cloud/vm/UserVmManagerImpl.java | 4 +-
.../cloudstack/backup/BackupManagerImpl.java | 3 +-
.../storage/heuristics/HeuristicRuleHelper.java | 16 +-
.../storage/template/VnfTemplateManagerImpl.java | 21 +-
.../cloudstack/vm/schedule/VMSchedulerImpl.java | 8 +-
.../cloud/resource/ResourceManagerImplTest.java | 26 +-
.../ResourceLimitManagerImplTest.java | 10 +-
.../com/cloud/storage/StorageManagerImplTest.java | 56 ++-
.../storage/snapshot/SnapshotManagerImplTest.java | 4 +-
.../template/HypervisorTemplateAdapterTest.java | 27 +-
.../cloud/template/TemplateManagerImplTest.java | 28 ++
.../java/com/cloud/vm/UserVmManagerImplTest.java | 7 +-
.../java/com/cloud/vpc/MockNetworkManagerImpl.java | 7 +
.../template/VnfTemplateManagerImplTest.java | 8 +-
.../SecondaryStorageManagerImpl.java | 6 +-
tools/marvin/marvin/lib/base.py | 3 +-
ui/public/config.json | 3 +-
ui/public/locales/en.json | 10 +-
ui/public/locales/pt_BR.json | 1 +
ui/src/components/view/DedicateDomain.vue | 129 ++---
ui/src/components/view/SearchFilter.vue | 559 +++++++++++++++++++++
ui/src/components/widgets/InfiniteScrollSelect.vue | 91 +++-
ui/src/config/section/image.js | 6 +-
ui/src/config/section/network.js | 5 +-
ui/src/utils/plugins.js | 13 +-
ui/src/views/AutogenView.vue | 48 ++
ui/src/views/auth/ForgotPassword.vue | 2 +-
ui/src/views/compute/DeployVM.vue | 4 +-
ui/src/views/compute/DeployVnfAppliance.vue | 16 +-
ui/src/views/compute/wizard/OwnershipSelection.vue | 30 +-
ui/src/views/compute/wizard/VnfNicsSelection.vue | 5 +
ui/src/views/iam/AddUser.vue | 121 ++---
ui/src/views/image/RegisterOrUploadTemplate.vue | 6 +-
ui/src/views/infra/AddSecondaryStorage.vue | 82 ++-
ui/src/views/infra/UsageRecords.vue | 112 +++--
ui/src/views/infra/zone/ZoneWizardAddResources.vue | 25 +-
ui/src/views/infra/zone/ZoneWizardLaunchZone.vue | 5 +
ui/src/views/network/CreateIsolatedNetworkForm.vue | 2 +-
ui/src/views/network/CreateL2NetworkForm.vue | 2 +-
ui/src/views/network/VnfAppliancesTab.vue | 2 +-
ui/src/views/storage/CreateSharedFS.vue | 8 +-
ui/src/views/storage/CreateTemplate.vue | 111 ++--
ui/src/views/storage/CreateVolume.vue | 4 +-
ui/src/views/storage/UploadLocalVolume.vue | 225 ++++-----
ui/src/views/storage/UploadVolume.vue | 216 ++++----
ui/src/views/tools/CreateWebhook.vue | 124 ++---
ui/src/views/tools/ManageVolumes.vue | 157 +++---
ui/tests/unit/views/AutogenView.spec.js | 4 +
.../java/com/cloud/usage/UsageManagerImpl.java | 40 +-
utils/src/main/java/com/cloud/utils/UriUtils.java | 8 +-
.../main/java/com/cloud/utils/script/Script.java | 121 +++--
.../main/java/com/cloud/utils/ssh/SshHelper.java | 73 ++-
.../apache/cloudstack/utils/usage/UsageUtils.java | 51 ++
.../java/com/cloud/utils/script/ScriptTest.java | 30 ++
.../java/com/cloud/utils/ssh/SshHelperTest.java | 60 +++
.../cloudstack/utils/usage/UsageUtilsTest.java | 135 +++++
179 files changed, 4217 insertions(+), 1769 deletions(-)
copy engine/schema/src/main/java/com/cloud/upgrade/dao/{Upgrade441to442.java
=> Upgrade42020to42030.java} (82%)
copy
engine/schema/src/main/resources/META-INF/db/{schema-41310to41400-cleanup.sql
=> schema-42020to42030.sql} (57%)
create mode 100644
plugins/storage/volume/linstor/src/main/java/org/apache/cloudstack/storage/motion/LinstorDataMotionStrategy.java
create mode 100644 ui/src/components/view/SearchFilter.vue
create mode 100644
utils/src/test/java/org/apache/cloudstack/utils/usage/UsageUtilsTest.java
