sureshanaparti commented on code in PR #12549:
URL: https://github.com/apache/cloudstack/pull/12549#discussion_r2744960676
##########
plugins/backup/nas/src/main/java/org/apache/cloudstack/backup/NASBackupProvider.java:
##########
@@ -215,7 +215,7 @@ private BackupVO createBackupObject(VirtualMachine vm,
String backupPath) {
public boolean restoreVMFromBackup(VirtualMachine vm, Backup backup) {
List<Backup.VolumeInfo> backedVolumes = backup.getBackedUpVolumes();
List<VolumeVO> volumes = backedVolumes.stream()
- .map(volume -> volumeDao.findByUuid(volume.getUuid()))
+ .map(volume -> volumeDao.findByUuid(volume.getPath()))
Review Comment:
```suggestion
.map(backedVolumeInfo ->
volumeDao.findByUuid(backedVolumeInfo.getPath()))
```
it's better change to _backedVolumeInfo_ to avoid confusion.
@Pearl1594 Correct, path of the backup doesn't change. I mean, the volume
path after migration might change as the volume is checked by its backed up
path (which is before migration). cc @abh1sar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
