abh1sar opened a new pull request, #12555: URL: https://github.com/apache/cloudstack/pull/12555
### Description This PR fixes #11272 On revert to an instance snapshot, VM instance details were fully replaced with only the snapshot-stored details (CPU_NUMBER, CPU_SPEED, MEMORY) for dynamic service offerings, so any other details (e.g. boot/UEFI, keyboard, or other custom settings) were lost. This change updates revert to only restore those three service-offering details via addDetail, leaving all other VM instance details unchanged. <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. --> <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> <!--- ******************************************************************************* --> <!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. --> <!--- PLEASE PUT AN 'X' in only **ONE** box --> <!--- ******************************************************************************* --> ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] Build/CI - [ ] Test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [ ] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [x] Major - [ ] Minor - [ ] Trivial ### Screenshots (if appropriate): Before fix: Initial settings <img width="1200" height="423" alt="Screenshot 2026-01-30 at 2 44 53 PM" src="https://github.com/user-attachments/assets/ed067f3c-2210-4512-af36-5e1b674ef5ba"; /> Settings after snapshot revert <img width="1200" height="431" alt="Screenshot 2026-01-30 at 2 45 12 PM" src="https://github.com/user-attachments/assets/4f0a1d61-2012-4c30-bb23-3bcecd7e41c6"; /> ### How Has This Been Tested? 1. Create a custom service offering 2. Create an instance with the custom service offering 3. Shut down Instance and set UEFI=Secure in Instance settings 4. Start Instance Create Instance snapshot (with or without memory) 5. Stop Instance and Revert to Snapshot 6. Start Instance 7. Verify that none of the VM settings are lost. <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> #### How did you try to break this feature and the system with this change? <!-- see how your change affects other areas of the code, etc. --> <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
