bhouse-nexthop commented on issue #12574: URL: https://github.com/apache/cloudstack/issues/12574#issuecomment-3849269005
> > I also need to know what else I may be missing before I start trying to build and test this. > > [@bradh352](https://github.com/bradh352) , I will not be complete, but > > * a manager will have to read the value in the right call > * you'll have to think of the dynamics of updates (restart needed? Of the router/management server?) > * find the right call or create a new one to re-configure the router > * you must think about getting the value to the router in a TO (transfer object) > * you probably already know that on the router, the application of the value is done in the python scripts > * ... I'm pretty sure all this is handled in the current PR. I modeled it off the max conns for haproxy for the most part, which appears to be completely dynamic (no restart needed). I implemented the necessary unit tests to validate the change, and also added the healthcheck script on the VR to evaluate the options are indeed set as expected. It builds and unit tests pass ... I just need to manually build the .deb with this patch applied to the 4.22.0.0 release (along with a couple other PRs I use), and see if it *really* works I guess. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
