DaanHoogland commented on issue #12574: URL: https://github.com/apache/cloudstack/issues/12574#issuecomment-3851828544
@bradh352 , seen the pr and looks good to me (pending testing) 1. I do see a slight functional problem (in hindsight) akin to your reply to @chunkyen ; Do we really want all networks to have the same proxy timeout? I could imagine different applications requiring different settings. That said, this is certainly a good enhancement 2. did you test the upgrade scenario? it seems not exiting, but it might . I don’t see these remarks as a blocker to your PR atm. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
