DaanHoogland commented on code in PR #12391:
URL: https://github.com/apache/cloudstack/pull/12391#discussion_r2797576407


##########
framework/config/src/main/java/org/apache/cloudstack/framework/config/ConfigKey.java:
##########
@@ -400,6 +400,13 @@ protected T valueInGlobalOrAvailableParentScope(Scope 
scope, Long id) {
         return value();
     }
 
+    /**
+     * Use {@link ConfigKey#valueInScope(Scope, Long)} instead.
+     */
+    public T valueInDomain(Long domainId) {
+        return valueInScope(Scope.Domain, domainId);
+    }

Review Comment:
   ```suggestion
       /**
       * @deprecated
        * Still used by some external code but, use {@link 
ConfigKey#valueInScope(Scope, Long)} instead.
        */
       @Deprecated
       public T valueInDomain(Long domainId) {
           return valueInScope(Scope.Domain, domainId);
       }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to