Copilot commented on code in PR #12640:
URL: https://github.com/apache/cloudstack/pull/12640#discussion_r2804512127
##########
pom.xml:
##########
@@ -465,8 +465,8 @@
<version>${cs.reload4j.version}</version>
</dependency>
<dependency>
- <groupId>mysql</groupId>
- <artifactId>mysql-connector-java</artifactId>
+ <groupId>com.mysql</groupId>
+ <artifactId>mysql-connector-j</artifactId>
<version>${cs.mysql.version}</version>
<scope>test</scope>
</dependency>
Review Comment:
This dependency declaration for mysql-connector-j appears to be duplicated.
The same dependency (com.mysql:mysql-connector-j with scope test) is declared
again at lines 484-489 in the same dependencyManagement section. One of these
duplicate entries should be removed to avoid confusion and potential
maintenance issues.
##########
setup/db/deploy-db-dev.sh:
##########
@@ -104,9 +104,9 @@ CP=./
CP=${CP}$PATHSEP$CATALINA_HOME/conf
-# Add mysql jar from mysql-connector-java package to CP
+# Add mysql jar from mysql-connector-j package to CP
# for Jenkins
-CP=${CP}${PATHSEP}/usr/share/java/mysql-connector-java.jar
+CP=${CP}${PATHSEP}/usr/share/java/mysql-connector-j-8.4.0.jar
Review Comment:
The JAR filename is hardcoded with version 8.4.0. This creates a maintenance
burden as it will need to be updated with each MySQL connector version change.
Consider using a wildcard pattern like
'/usr/share/java/mysql-connector-j-*.jar' to make the script more
version-agnostic, or if wildcards don't work in the CLASSPATH construction,
consider using a find command or a symbolic link without the version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
