Copilot commented on code in PR #12652:
URL: https://github.com/apache/cloudstack/pull/12652#discussion_r2815750826
##########
.gitattributes:
##########
@@ -0,0 +1 @@
+.github/workflows/*.lock.yml linguist-generated=true merge=ours
Review Comment:
This new `.gitattributes` file does not include the standard ASF license
header used in other repo root config files, which may cause the RAT license
check to fail. Add the ASF header (as `#` comments) or explicitly exclude
`.gitattributes` from the RAT plugin configuration.
##########
pom.xml:
##########
@@ -1087,6 +1087,9 @@
<exclude>utils/testsmallfileinactive</exclude>
<exclude>**/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker</exclude>
<exclude>.github/workflows/dependabot.yaml</exclude>
+ <exclude>.github/workflows/*.md</exclude>
+ <exclude>.github/workflows/*.lock.md</exclude>
Review Comment:
The RAT plugin exclude list adds `.github/workflows/*.lock.md`, but the
generated workflows in this PR are `.github/workflows/*.lock.yml`. As-is, RAT
will still scan the new lock files (which don’t contain ASF headers) and likely
fail the build. Update the excludes to match `*.lock.yml` (and consider
excluding all `*.lock.ya?ml` if both extensions are possible).
```suggestion
<exclude>.github/workflows/*.lock.md</exclude>
<exclude>.github/workflows/*.lock.ya?ml</exclude>
```
##########
.pre-commit-config.yaml:
##########
@@ -195,4 +196,4 @@ repos:
args: [--config-file=.github/linters/.yamllint.yml]
types: [yaml]
files: \.ya?ml$
- exclude: ^.*k8s-.*\.ya?ml$
+ exclude:
^.*k8s-.*\.ya?ml$|^.github/workflows/daily-repo-status\.lock\.ya?ml$|^.github/workflows/issue-triage-agent.lock.yml$
Review Comment:
The `yamllint` hook’s `exclude` regex uses `|^.github/...` (dot not
escaped), so it will also match paths like `xgithub/...` unintentionally.
Escape the leading dot (`^\.github/...`) for both added patterns to avoid
excluding non-workflow YAML files by accident.
```suggestion
exclude:
^.*k8s-.*\.ya?ml$|^\.github/workflows/daily-repo-status\.lock\.ya?ml$|^\.github/workflows/issue-triage-agent.lock.yml$
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
