Copilot commented on code in PR #12764:
URL: https://github.com/apache/cloudstack/pull/12764#discussion_r2910778378
##########
ui/src/views/network/CreateVpnCustomerGateway.vue:
##########
@@ -258,9 +258,13 @@ export default {
'Group 15': 'modp3072',
'Group 16': 'modp4096',
'Group 17': 'modp6144',
- 'Group 18': 'modp8192'
+ 'Group 18': 'modp8192',
+ 'Group 22': 'modp1024s160',
+ 'Group 23': 'modp2048s224',
+ 'Group 24': 'modp2048s256',
+ 'Group 31': 'curve25519'
},
- ikeDhGroupInitialValue: 'Group 5(modp1536)',
+ ikeDhGroupInitialValue: 'Group 31(curve25519)',
Review Comment:
`ikeDhGroupInitialValue` is set to a label-like string (`Group
31(curve25519)`), but the `<a-select>` for IKE DH uses
`:value="DHGroups[group]"` (e.g. `curve25519`). This mismatch makes the
initial-value comparison in `handleSubmit` unreliable and contributes to
generating invalid `ikepolicy` values. Set `ikeDhGroupInitialValue` to the
actual option value (e.g. `curve25519`) or remove the special-casing logic
entirely and always append `values.ikeDh`.
```suggestion
ikeDhGroupInitialValue: 'curve25519',
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
