DaanHoogland commented on code in PR #12779:
URL: https://github.com/apache/cloudstack/pull/12779#discussion_r2924539972
##########
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##########
@@ -5809,18 +5733,19 @@ public Pair<UserVmVO, Map<VirtualMachineProfile.Param,
Object>> startVirtualMach
// use it to encrypt & save the vm password
encryptAndStorePassword(vm, password);
- params = createParameterInParameterMap(params, additionalParams,
VirtualMachineProfile.Param.VmPassword, password);
+ // overwrite VmPassword
+ params = createParameterInParameterMap(params,
VirtualMachineProfile.Param.VmPassword, password);
}
if(additionalParams.containsKey(VirtualMachineProfile.Param.BootIntoSetup)) {
if (! HypervisorType.VMware.equals(vm.getHypervisorType())) {
throw new
InvalidParameterValueException(ApiConstants.BOOT_INTO_SETUP + " makes no sense
for " + vm.getHypervisorType());
}
+
+ //overwrite BootIntoSetup
Object paramValue =
additionalParams.get(VirtualMachineProfile.Param.BootIntoSetup);
- if (logger.isTraceEnabled()) {
- logger.trace("It was specified whether to enter setup
mode: " + paramValue.toString());
- }
- params = createParameterInParameterMap(params, additionalParams,
VirtualMachineProfile.Param.BootIntoSetup, paramValue);
+ logger.trace("It was specified whether to enter setup mode: {}",
paramValue.toString());
Review Comment:
```suggestion
logger.trace("It was specified whether to enter setup mode: {}",
paramValue);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
