erikbocks commented on code in PR #12939:
URL: https://github.com/apache/cloudstack/pull/12939#discussion_r3021684212


##########
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##########
@@ -2713,22 +2714,29 @@ private void updateVmStateForFailedVmCreation(Long 
vmId, Long hostId) {
         if (vm != null) {
             if (vm.getState().equals(State.Stopped)) {
                 HostVO host = _hostDao.findById(hostId);
-                logger.debug("Destroying vm {} as it failed to create on Host: 
{} with id {}", vm, host, hostId);
+                logger.debug("Destroying vm [{}] as it was unable to be 
deployed on Host: {} with id {}", vm, host, hostId);

Review Comment:
   ```suggestion
                   logger.debug("Destroying VM [{}] as it was unable to be 
deployed on Host: {}.", vm, host);
   ```
   
   Maybe we don't have to log the ID again, as it is already present at the 
host's `toString()`. What do you think about it, @GaOrtiga?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to