sureshanaparti commented on code in PR #12970:
URL: https://github.com/apache/cloudstack/pull/12970#discussion_r3063924187
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -1156,6 +1186,39 @@ public boolean configure(final String name, final
Map<String, Object> params) th
setConvertInstanceEnv(convertEnvTmpDir, convertEnvVirtv2vTmpDir);
+ vddkLibDir =
StringUtils.trimToNull(AgentPropertiesFileHandler.getPropertyValue(AgentProperties.VDDK_LIB_DIR));
+ if (StringUtils.isNotBlank(vddkLibDir) &&
!isVddkLibDirValid(vddkLibDir)) {
+ LOGGER.warn("Configured VDDK library dir [{}] is invalid (missing
lib64/libvixDiskLib.so), attempting auto-detection", vddkLibDir);
+ vddkLibDir = null;
+ }
+ if (StringUtils.isBlank(vddkLibDir)) {
+ vddkLibDir = detectVddkLibDir();
+ }
+ if (StringUtils.isNotBlank(vddkLibDir)) {
+ LOGGER.info("Detected VDDK library dir: {}", vddkLibDir);
+ } else {
+ LOGGER.warn("Could not detect a valid VDDK library dir; VDDK
conversion will be unavailable");
+ }
+
+ vddkVersion = detectVddkVersion();
+ if (StringUtils.isNotBlank(vddkVersion)) {
+ LOGGER.info("Detected nbdkit VDDK plugin version: {}",
vddkVersion);
+ }
+
+ libguestfsBackend = StringUtils.defaultIfBlank(
Review Comment:
```suggestion
```
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -1156,6 +1186,39 @@ public boolean configure(final String name, final
Map<String, Object> params) th
setConvertInstanceEnv(convertEnvTmpDir, convertEnvVirtv2vTmpDir);
+ vddkLibDir =
StringUtils.trimToNull(AgentPropertiesFileHandler.getPropertyValue(AgentProperties.VDDK_LIB_DIR));
+ if (StringUtils.isNotBlank(vddkLibDir) &&
!isVddkLibDirValid(vddkLibDir)) {
+ LOGGER.warn("Configured VDDK library dir [{}] is invalid (missing
lib64/libvixDiskLib.so), attempting auto-detection", vddkLibDir);
+ vddkLibDir = null;
+ }
+ if (StringUtils.isBlank(vddkLibDir)) {
+ vddkLibDir = detectVddkLibDir();
+ }
+ if (StringUtils.isNotBlank(vddkLibDir)) {
+ LOGGER.info("Detected VDDK library dir: {}", vddkLibDir);
+ } else {
+ LOGGER.warn("Could not detect a valid VDDK library dir; VDDK
conversion will be unavailable");
+ }
+
+ vddkVersion = detectVddkVersion();
+ if (StringUtils.isNotBlank(vddkVersion)) {
+ LOGGER.info("Detected nbdkit VDDK plugin version: {}",
vddkVersion);
+ }
+
+ libguestfsBackend = StringUtils.defaultIfBlank(
+
AgentPropertiesFileHandler.getPropertyValue(AgentProperties.LIBGUESTFS_BACKEND),
"direct");
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
