dheeraj12347 opened a new pull request, #13002:
URL: https://github.com/apache/cloudstack/pull/13002
Fixes #12810.
Changes:
-
services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxy.java
- Add static field sessionTimeoutMillis with a default of 300000 ms (5
minutes).
- Read the global setting consoleproxy.session.timeout from the
configuration and set sessionTimeoutMillis accordingly, with logging and
validation.
- Pass the timeout information to ConsoleProxyGCThread (via the shared
ConsoleProxy.sessionTimeoutMillis value).
-
services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyGCThread.java
- Replace the hard-coded MAX_SESSION_IDLE_SECONDS with
DEFAULT_MAX_SESSION_IDLE_SECONDS.
- Add getMaxSessionIdleSeconds() to derive the idle timeout from
ConsoleProxy.sessionTimeoutMillis (falling back to the default when the setting
is disabled or invalid).
- Use getMaxSessionIdleSeconds() when deciding whether to close idle
sessions.
-
services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyNoVNCHandler.java
- Set the Jetty WebSocket Session idle timeout from
ConsoleProxy.sessionTimeoutMillis.
- Improve error logging in onError() to include the exception only when
the viewer is available, and add a separate log message for errors before
viewer initialization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
