dheeraj12347 commented on code in PR #13002:
URL: https://github.com/apache/cloudstack/pull/13002#discussion_r3098179958
##########
services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyGCThread.java:
##########
@@ -45,6 +45,13 @@ public ConsoleProxyGCThread(Map<String, ConsoleProxyClient>
connMap, Set<String>
this.removedSessionsSet = removedSet;
}
+ private int getMaxSessionIdleSeconds() {
+ if (ConsoleProxy.sessionTimeoutMillis <= 0) {
+ return DEFAULT_MAX_SESSION_IDLE_SECONDS;
+ }
+ return ConsoleProxy.sessionTimeoutMillis / 1000;
+ }
+
Review Comment:
I updated getMaxSessionIdleSeconds() to return
DEFAULT_MAX_SESSION_IDLE_SECONDS when sessionTimeoutMillis <= 0 and to clamp
the derived value with Math.max(1, ConsoleProxy.sessionTimeoutMillis / 1000),
so 1–999 ms now map to 1 second instead of 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
