jmsperu opened a new pull request, #13074: URL: https://github.com/apache/cloudstack/pull/13074
## Summary Implements incremental backup support for the NAS backup provider on KVM, using QEMU dirty bitmaps and libvirt's `backup-begin` API. This is the implementation of RFC #12899. For large VMs, this reduces daily backup storage 80–95% and shortens backup windows from hours to minutes (e.g. a 500 GB VM with moderate writes goes from ~500 GB/day to ~5–15 GB/day after the initial full backup). ## Status 🚧 **Work in Progress.** Opening as a draft so reviewers (cc @abh1sar @JoaoJandre @harikrishna-patnala @weizhouapache) have a stable place to track progress. This first commit adds only the RFC document (incorporating all review feedback from the issue thread). Implementation will land as follow-up commits on this branch. ## Scope per agreed plan Based on the discussion in #12899, this PR will deliver in subsequent commits: - [x] RFC document committed (this commit) - [ ] `BackupDetailKeys` constants for chain metadata stored in existing `backup_details` kv table (per @JoaoJandre — no new columns on `backups`) - [ ] `nas.backup.full.every` ConfigKey (count-based, default 10) — replaces the original day-based interval (per @abh1sar) - [ ] `nasbackup.sh` extended with `MODE=full|incremental`, using `virsh backup-begin` for both modes on running VMs (per @abh1sar #2, #4) - [ ] Timestamp-based bitmap names (per @abh1sar #3) - [ ] `qemu-img rebase` immediately after each incremental (per @abh1sar #5) - [ ] Stopped-VM behavior: full backup only; incremental falls back to full (per @abh1sar #6 — simplest of the two options I proposed) - [ ] Cascade delete logic via `chain_position` in `backup_details` (per @abh1sar #7) - [ ] Bitmap recreation on VM start (CloudStack rebuilds domain XML — bitmaps are lost) (per @abh1sar #8) - [ ] Smoke test additions in `test/integration/smoke/test_backup_recovery_nas.py` ## RFC document Full design at `docs/rfcs/incremental-nas-backup.md`. ## Refs - Issue: #12899 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
