jmsperu commented on PR #13074: URL: https://github.com/apache/cloudstack/pull/13074#issuecomment-4333639555
@weizhouapache yes — ready for review. @sureshanaparti — apologies, I missed your earlier ping. The build failure was a unit test in `LibvirtRestoreBackupCommandWrapperTest.testExecuteWithRsyncFailure` (NPE on `currentDevice` after my new chain-flatten check incorrectly routed the test through the qemu-img convert path). Fixed in d80ed16723: the test's `Script.runSimpleBashScriptForExitValue` mock now returns 1 (no backing chain) for the new `qemu-img info | grep "backing-filename"` probe, so the test continues to exercise the rsync path it was designed for. CI should be green on the next run. Cc @abh1sar @JoaoJandre @harikrishna-patnala in case you also want to take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
