winterhazel commented on code in PR #13053:
URL: https://github.com/apache/cloudstack/pull/13053#discussion_r3181932965
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/IscsiAdmStorageAdaptor.java:
##########
@@ -280,8 +329,96 @@ private String getComponent(String path, int index) {
return tmp[index].trim();
}
+ /**
+ * Check if there are other LUNs on the same iSCSI target (IQN) that are
still
+ * visible as block devices. This is needed because ONTAP uses a single
IQN per
+ * SVM — logging out of the target would kill ALL LUNs, not just the one
being
+ * disconnected.
+ *
+ * Checks /dev/disk/by-path/ for symlinks matching the same host:port +
IQN but
+ * with a different LUN number.
+ */
+ private boolean hasOtherActiveLuns(String host, int port, String iqn,
String lun) {
+ String prefix = "ip-" + host + ":" + port + "-iscsi-" + iqn + "-lun-";
+ java.io.File byPathDir = new java.io.File("/dev/disk/by-path");
Review Comment:
Please import the `File` class and use only the classname
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
