winterhazel commented on code in PR #13019: URL: https://github.com/apache/cloudstack/pull/13019#discussion_r3231010654
########## engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade42030to42040.java: ########## @@ -0,0 +1,58 @@ +// Licensed to the Apache Software Foundation (ASF) under one Review Comment: @abh1sar this change will allow duplicate usage record generation for running VMs, as two `usage_vm_instance` helper records will exist (I think) after executing the Usage job with duplicate `VM.START` events. Instead of removing the foreign key, I think that it makes more change to investigate why duplicated `VM.START` events are being generated, fixing it, and removing existing duplicate records. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
