Pearl1594 commented on code in PR #13158:
URL: https://github.com/apache/cloudstack/pull/13158#discussion_r3237987098
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/vm/ImportVmCmd.java:
##########
@@ -107,6 +106,18 @@ public class ImportVmCmd extends
ImportUnmanagedInstanceCmd {
description = "the network ID")
private Long networkId;
+ @Parameter(name = ApiConstants.MAC_ADDRESS,
+ type = CommandType.STRING,
+ since = "4.22.1",
Review Comment:
```suggestion
since = "4.23.0",
```
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/vm/ImportUnmanagedInstanceCmd.java:
##########
@@ -118,6 +119,13 @@ public class ImportUnmanagedInstanceCmd extends
BaseAsyncCmd {
description = "The ID of the Template for the Instance")
private Long templateId;
+ @Parameter(name = ApiConstants.OS_ID,
+ type = CommandType.UUID,
+ entityType = GuestOSResponse.class,
+ since = "4.22.1",
Review Comment:
```suggestion
since = "4.23.0",
```
##########
ui/src/views/tools/ImportUnmanagedInstance.vue:
##########
@@ -262,6 +262,24 @@
<a-span v-else>{{
$t('label.no.matching.guest.os.vmware.import') }}</a-span>
</template>
</a-form-item>
+ <a-form-item name="osid" ref="osid" v-if="showOsTypeSelection">
+ <template #label>
+ <tooltip-label :title="$t('label.guest.os')"
:tooltip="$t('label.select.guest.os.type')"/>
Review Comment:
```suggestion
<tooltip-label :title="$t('label.guest.os')"
:tooltip="apiParams.osid.description"/>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
