winterhazel commented on code in PR #13186:
URL: https://github.com/apache/cloudstack/pull/13186#discussion_r3267660689
##########
framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/model/impl/DefaultModuleDefinitionSet.java:
##########
@@ -147,10 +148,11 @@ public void with(ModuleDefinition def,
Stack<ModuleDefinition> parents) {
logger.debug("Failed to obtain module context: ", e);
}
} catch (BeansException e) {
- logger.warn(String.format("Failed to start module [%s] due
to: [%s].", def.getName(), e.getMessage()));
+ logger.warn(String.format("Failed to load module [%s] due
to: [%s].", def.getName(), e.getMessage()));
if (logger.isDebugEnabled()) {
- logger.debug(String.format("module start failure of
module [%s] was due to: ", def.getName()), e);
+ logger.debug(String.format("module load failure of
module [%s] was due to: ", def.getName()), e);
}
Review Comment:
```suggestion
logger.error("Failed to load module [{}] due to: [{}]",
def.getName(), e));
```
We can change the 1st log from warn to error, as it will result in a startup
failure, and remove the 2nd one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
