winterhazel commented on code in PR #13210:
URL: https://github.com/apache/cloudstack/pull/13210#discussion_r3304131545
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java:
##########
@@ -2061,7 +2061,7 @@ private void convertTheBaseFileToSnapshot(KVMPhysicalDisk
baseFile, String snaps
QemuImgFile destFile = new QemuImgFile(snapshotPath);
destFile.setFormat(PhysicalDiskFormat.QCOW2);
- QemuImg q = new QemuImg(wait);
+ QemuImg q = new QemuImg(wait * 1000);
Review Comment:
Echoing what @DaanHoogland pointed in
https://github.com/apache/cloudstack/pull/13212#discussion_r3287372535: QemuImg
currently receives an int for the timeout. Does it make sense to change it to a
long in order to avoid overflows?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
