erikbocks commented on code in PR #13210:
URL: https://github.com/apache/cloudstack/pull/13210#discussion_r3313530274


##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java:
##########
@@ -2061,7 +2061,7 @@ private void convertTheBaseFileToSnapshot(KVMPhysicalDisk 
baseFile, String snaps
         QemuImgFile destFile = new QemuImgFile(snapshotPath);
         destFile.setFormat(PhysicalDiskFormat.QCOW2);
 
-        QemuImg q = new QemuImg(wait);
+        QemuImg q = new QemuImg(wait * 1000);

Review Comment:
   I think that was a great catch. I've implemented the QemuImg helper changes 
in the 
[a55e19df937226801cae6a870e45d1d3d31412c7](https://github.com/apache/cloudstack/pull/13212/changes/a55e19df937226801cae6a870e45d1d3d31412c7)
 commit from #13212, then ported the commit to this branch. I've built the 
packages with tests and no error was thrown. I will try to validate if the 
behavior was mantained later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to