Copilot commented on code in PR #12567:
URL: https://github.com/apache/cloudstack/pull/12567#discussion_r3310854299
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java:
##########
@@ -4957,7 +4957,6 @@ public ConfigKey<?>[] getConfigKeys() {
return new ConfigKey<?>[]{NetworkGcWait, NetworkGcInterval,
NetworkLockTimeout, DeniedRoutes,
GuestDomainSuffix, NetworkThrottlingRate, MinVRVersion,
PromiscuousMode, MacAddressChanges, ForgedTransmits,
MacLearning, RollingRestartEnabled,
- TUNGSTEN_ENABLED, NSX_ENABLED, NETRIS_ENABLED,
NETWORK_LB_HAPROXY_MAX_CONN,
- NETWORK_LB_HAPROXY_IDLE_TIMEOUT};
+ TUNGSTEN_ENABLED, NSX_ENABLED, NETRIS_ENABLED,
NETWORK_LB_HAPROXY_MAX_CONN, VmNetworkThrottlingRate};
Review Comment:
`NETWORK_LB_HAPROXY_IDLE_TIMEOUT` was removed from the `getConfigKeys()`
return list. This key is still referenced elsewhere via
`NetworkOrchestrationService.NETWORK_LB_HAPROXY_IDLE_TIMEOUT.value()`, and
omitting it here can prevent the key from being registered/synced by the
ConfigDepot (e.g., disappearing from listConfigurations / dynamic metadata
updates). Re-add `NETWORK_LB_HAPROXY_IDLE_TIMEOUT` to the returned array along
with the newly-added `VmNetworkThrottlingRate`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
