GaOrtiga commented on code in PR #13236:
URL: https://github.com/apache/cloudstack/pull/13236#discussion_r3313062168
##########
framework/quota/src/main/java/org/apache/cloudstack/quota/QuotaManagerImpl.java:
##########
@@ -348,31 +365,41 @@ protected boolean shouldCalculateUsageRecord(AccountVO
accountVO, UsageVO usageR
return true;
}
- protected List<QuotaUsageVO>
persistUsagesAndQuotaUsagesAndRetrievePersistedQuotaUsages(List<Pair<UsageVO,
QuotaUsageVO>> pairsUsageAndQuotaUsage) {
- List<QuotaUsageVO> quotaUsages = new ArrayList<>();
+ protected List<QuotaUsageVO>
persistUsagesAndQuotaUsagesAndRetrievePersistedQuotaUsages(Map<UsageVO,
Pair<QuotaUsageVO, List<QuotaTariffUsageVO>>> mapUsageAndQuotaTariffUsage) {
+ List<QuotaUsageVO> quotaUsages = new ArrayList<>(); // TODO: isso tem
que ser em uma transação
Review Comment:
@winterhazel Has this been addressed? or can we just delete the comment
##########
framework/quota/src/main/java/org/apache/cloudstack/quota/QuotaManagerImpl.java:
##########
@@ -348,31 +365,41 @@ protected boolean shouldCalculateUsageRecord(AccountVO
accountVO, UsageVO usageR
return true;
}
- protected List<QuotaUsageVO>
persistUsagesAndQuotaUsagesAndRetrievePersistedQuotaUsages(List<Pair<UsageVO,
QuotaUsageVO>> pairsUsageAndQuotaUsage) {
- List<QuotaUsageVO> quotaUsages = new ArrayList<>();
+ protected List<QuotaUsageVO>
persistUsagesAndQuotaUsagesAndRetrievePersistedQuotaUsages(Map<UsageVO,
Pair<QuotaUsageVO, List<QuotaTariffUsageVO>>> mapUsageAndQuotaTariffUsage) {
+ List<QuotaUsageVO> quotaUsages = new ArrayList<>(); // TODO: isso tem
que ser em uma transação
Review Comment:
@winterhazel Has this been addressed? or can we just delete the comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
