DaanHoogland commented on code in PR #13236:
URL: https://github.com/apache/cloudstack/pull/13236#discussion_r3316109034
##########
plugins/database/quota/src/main/java/org/apache/cloudstack/api/response/QuotaStatementResponse.java:
##########
@@ -31,11 +31,11 @@ public class QuotaStatementResponse extends BaseResponse {
@Param(description = "ID of the Account.")
private String accountId;
- @SerializedName(ApiConstants.ACCOUNT)
+ @SerializedName(ApiConstants.ACCOUNT_NAME)
@Param(description = "Name of the Account.")
private String accountName;
- @SerializedName(ApiConstants.DOMAIN)
+ @SerializedName(ApiConstants.DOMAIN_ID)
Review Comment:
also a backwards incompatability?
##########
plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaStatementCmd.java:
##########
@@ -20,7 +20,6 @@
import javax.inject.Inject;
-import org.apache.cloudstack.api.ACL;
Review Comment:
so some access validation is being skipped now. Wat is the ratio on this?
##########
plugins/database/quota/src/main/java/org/apache/cloudstack/api/response/QuotaStatementResponse.java:
##########
@@ -31,11 +31,11 @@ public class QuotaStatementResponse extends BaseResponse {
@Param(description = "ID of the Account.")
private String accountId;
- @SerializedName(ApiConstants.ACCOUNT)
+ @SerializedName(ApiConstants.ACCOUNT_NAME)
Review Comment:
this seem a backwards incompatability, is it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
