weizhouapache commented on code in PR #13281:
URL: https://github.com/apache/cloudstack/pull/13281#discussion_r3323344710


##########
python/lib/cloudutils/serviceConfig.py:
##########
@@ -559,6 +563,8 @@ def __init__(self, syscfg):
         self.serviceName = "SElinux"
 
     def config(self):
+        return True

Review Comment:
   
   IMHO, this should work
   ```
   setenforce 1 (enforcing mode)
   security_driver="none"
   ```
   
   I am not sure if it works when security_driver is not set, or set to 
"selinux"
   
   if not,  we need to document it, or set it to "none".
   anyway, it is not good to set selinux to permissive mode globally.
   enforcing mode should be supported.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to