weizhouapache commented on code in PR #13319:
URL: https://github.com/apache/cloudstack/pull/13319#discussion_r3343617293
##########
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java:
##########
@@ -545,7 +545,7 @@ protected Answer migrateVolumeToPool(DataObject srcData,
DataObject destData) {
VolumeInfo volume = (VolumeInfo)srcData;
StoragePool srcPool =
(StoragePool)dataStoreMgr.getDataStore(srcData.getDataStore().getId(),
DataStoreRole.Primary);
StoragePool destPool =
(StoragePool)dataStoreMgr.getDataStore(destData.getDataStore().getId(),
DataStoreRole.Primary);
- MigrateVolumeCommand command = new
MigrateVolumeCommand(volume.getId(), volume.getPath(), destPool,
volume.getAttachedVmName(), volume.getVolumeType(), waitInterval,
volume.getChainInfo());
+ MigrateVolumeCommand command = new
MigrateVolumeCommand(srcData.getTO(), destData.getTO(), null, null,
waitInterval);
Review Comment:
this will have huge impact
##########
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java:
##########
@@ -3531,9 +3531,8 @@ public Volume migrateVolume(MigrateVolumeCmd cmd) {
StoragePoolVO destinationStoragePoolVo =
_storagePoolDao.findById(storagePoolId);
if (isSourceOrDestNotOnStorPool(srcStoragePoolVO,
destinationStoragePoolVo)) {
- throw new InvalidParameterValueException("KVM does not
support volume live migration due to the limited possibility to refresh VM XML
domain. " +
- "Therefore, to live migrate a volume between
storage pools, one must migrate the VM to a different host as well to force the
VM XML domain update. " +
- "Use 'migrateVirtualMachineWithVolumes'
instead.");
+ logger.debug("Allowing KVM live volume migration
between different storage pools. VM [{}], volume [{}], source pool [{}],
destination pool [{}].",
Review Comment:
this will have huge impact too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
